-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid running tests when only docs are changed #148
Conversation
Test coverage for 68a812e
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this will work since we have required checks that must pass to be able to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the publishing workflow work if there's no charm to publish? Will it skip the step or break?
Responding to @jdkandersson and @arturo-seijas: I thought it would retain the status of the last CI. But it did launch it again so I put the PR into draft mode again. If I cannot confirm that:
I'll will not put it into ready again. |
You'll probably need to skip charm publishing in the operator workflows if the charm file is not present. That would probably suffice. You'll still need to launch the workflow because publishing, if enabled, is done there |
I'm closing this as I have made no progress and the issue is complex enough that we need more discussions |
Overview
Avoid running tests when only docs are changed.
Checklist
src-docs
urgent
,trivial
,complex
)