Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): Add PR Template #153

Merged
merged 3 commits into from
Dec 11, 2023
Merged

chore(github): Add PR Template #153

merged 3 commits into from
Dec 11, 2023

Conversation

merkata
Copy link
Contributor

@merkata merkata commented Dec 11, 2023

Adds a PR template, seems it is missing for this repo.

@merkata merkata requested a review from a team as a code owner December 11, 2023 08:03
yanksyoon
yanksyoon previously approved these changes Dec 11, 2023
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. Btw, the link to the contribution guide (which explains how-to generate src-docs) is broken. It should point to https://charmhub.io/discourse-k8s/docs/how-to-contribute

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Contributor

Test coverage for 97d0e49

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        325     31     82     11    90%   137, 171, 179-180, 336->341, 533-535, 540-541, 552-554, 559-560, 572-574, 579-580, 592-594, 619-621, 661->exit, 671->exit, 701-707, 733->exit, 747-748, 758->exit, 772
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               355     32     90     12    90%

Static code analysis report

Run started:2023-12-11 08:31:53.154807

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1944
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@merkata merkata merged commit a6f3864 into main Dec 11, 2023
8 of 9 checks passed
@merkata merkata deleted the chore/pr-templates branch December 11, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants