Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rolling restart by adding a dedicated callback method #177

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

nrobinaubertin
Copy link
Collaborator

Overview

Add handler method for rolling restart to be used as callback method for the RollingOpsManager.

Checklist

Copy link
Contributor

Test coverage for 5f09a4d

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        330     30     82     11    90%   177, 185-186, 350->355, 548-550, 555-556, 567-569, 574-575, 587-589, 594-595, 607-609, 634-636, 676->exit, 686->exit, 716-722, 748->exit, 762-763, 773->exit, 787
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               360     31     90     12    90%

Static code analysis report

Run started:2024-01-17 16:10:10.386452

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1984
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@merkata merkata merged commit 9c09b30 into main Jan 17, 2024
26 of 28 checks passed
@merkata merkata deleted the fix-rolling-restart branch January 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants