Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial to reflect new create-user action #263

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

mthaddon
Copy link
Contributor

@mthaddon mthaddon commented Jun 17, 2024

Overview

Trivial doc update for the tutorial to incorporate the new create-user action. I think changing the ordering a little to create the user before visiting the page makes sense too, as this will mean you get a "log in" prompt rather than a "register your first user" prompt.

Rationale

The action specified in the tutorial no longer exists, so update to include the new action.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@mthaddon mthaddon added documentation Improvements or additions to documentation trivial labels Jun 17, 2024
@mthaddon mthaddon requested a review from a team as a code owner June 17, 2024 10:05
Copy link
Contributor

Test coverage for 69831f8

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        371     41     94     15    88%   184, 192-193, 205, 337->345, 378->383, 395, 577-579, 584-585, 597-599, 604-605, 617-619, 642-644, 686->exit, 696->exit, 745-748, 758-759, 783-784, 796-797, 824-826, 828->833, 830-831, 873-874, 890-891, 901->exit, 915
src/database.py      29      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               400     42    102     16    88%

Static code analysis report

Run started:2024-06-17 12:15:44.421423

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2336
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthaddon mthaddon merged commit 3c2260e into main Jun 17, 2024
20 checks passed
@mthaddon mthaddon deleted the tutorial-create-user branch June 17, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: OK trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants