Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setuptools to 75.8.0 #433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update setuptools to 75.8.0 #433

wants to merge 1 commit into from

Conversation

weiiwang01
Copy link
Collaborator

Applicable spec:

Overview

Update setuptools to 75.8.0.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation is generated using src-docs.
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The changes do not introduce any regression in code or tests related to LXD runner mode.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 265 files.

Valid Invalid Ignored Fixed
0 69 196 0
Click to see the invalid file list
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • generate-src-docs.sh
  • metadata.yaml
  • pyproject.toml
  • scripts/build-lxd-image.sh
  • scripts/build-openstack-image.sh
  • scripts/pre-integration-test.sh
  • scripts/repo_policy_compliance_service.py
  • scripts/setup-lxd.sh
  • src/charm.py
  • src/charm_state.py
  • src/errors.py
  • src/event_timer.py
  • src/firewall.py
  • src/github_client.py
  • src/logrotate.py
  • src/lxd.py
  • src/lxd_type.py
  • src/runner.py
  • src/runner_manager.py
  • src/runner_manager_type.py
  • src/runner_type.py
  • src/shared_fs.py
  • src/utilities.py
  • tests/init.py
  • tests/conftest.py
  • tests/integration/init.py
  • tests/integration/conftest.py
  • tests/integration/data/clouds.yaml.tmpl
  • tests/integration/helpers/init.py
  • tests/integration/helpers/charm_metrics.py
  • tests/integration/helpers/common.py
  • tests/integration/helpers/lxd.py
  • tests/integration/helpers/openstack.py
  • tests/integration/test_charm_base_image.py
  • tests/integration/test_charm_fork_repo.py
  • tests/integration/test_charm_lxd_runner.py
  • tests/integration/test_charm_metrics_failure.py
  • tests/integration/test_charm_metrics_success.py
  • tests/integration/test_charm_no_runner.py
  • tests/integration/test_charm_runner.py
  • tests/integration/test_charm_scheduled_events.py
  • tests/integration/test_charm_upgrade.py
  • tests/integration/test_charm_with_juju_storage.py
  • tests/integration/test_charm_with_proxy.py
  • tests/integration/test_debug_ssh.py
  • tests/integration/test_e2e.py
  • tests/integration/test_reactive.py
  • tests/integration/test_runner_manager_openstack.py
  • tests/integration/test_self_hosted_runner.py
  • tests/status_name.py
  • tests/unit/init.py
  • tests/unit/conftest.py
  • tests/unit/factories.py
  • tests/unit/mock.py
  • tests/unit/mock_runner_managers.py
  • tests/unit/test_charm.py
  • tests/unit/test_charm_state.py
  • tests/unit/test_event_timer.py
  • tests/unit/test_firewall.py
  • tests/unit/test_logrotate.py
  • tests/unit/test_lxd_runner_manager.py
  • tests/unit/test_runner.py
  • tests/unit/test_runner_scaler.py
  • tests/unit/test_shared_fs.py
  • tests/unit/test_utilities.py
  • tox.ini
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 265 files.

Valid Invalid Ignored Fixed
0 69 196 0
Click to see the invalid file list
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • generate-src-docs.sh
  • metadata.yaml
  • pyproject.toml
  • scripts/build-lxd-image.sh
  • scripts/build-openstack-image.sh
  • scripts/pre-integration-test.sh
  • scripts/repo_policy_compliance_service.py
  • scripts/setup-lxd.sh
  • src/charm.py
  • src/charm_state.py
  • src/errors.py
  • src/event_timer.py
  • src/firewall.py
  • src/github_client.py
  • src/logrotate.py
  • src/lxd.py
  • src/lxd_type.py
  • src/runner.py
  • src/runner_manager.py
  • src/runner_manager_type.py
  • src/runner_type.py
  • src/shared_fs.py
  • src/utilities.py
  • tests/init.py
  • tests/conftest.py
  • tests/integration/init.py
  • tests/integration/conftest.py
  • tests/integration/data/clouds.yaml.tmpl
  • tests/integration/helpers/init.py
  • tests/integration/helpers/charm_metrics.py
  • tests/integration/helpers/common.py
  • tests/integration/helpers/lxd.py
  • tests/integration/helpers/openstack.py
  • tests/integration/test_charm_base_image.py
  • tests/integration/test_charm_fork_repo.py
  • tests/integration/test_charm_lxd_runner.py
  • tests/integration/test_charm_metrics_failure.py
  • tests/integration/test_charm_metrics_success.py
  • tests/integration/test_charm_no_runner.py
  • tests/integration/test_charm_runner.py
  • tests/integration/test_charm_scheduled_events.py
  • tests/integration/test_charm_upgrade.py
  • tests/integration/test_charm_with_juju_storage.py
  • tests/integration/test_charm_with_proxy.py
  • tests/integration/test_debug_ssh.py
  • tests/integration/test_e2e.py
  • tests/integration/test_reactive.py
  • tests/integration/test_runner_manager_openstack.py
  • tests/integration/test_self_hosted_runner.py
  • tests/status_name.py
  • tests/unit/init.py
  • tests/unit/conftest.py
  • tests/unit/factories.py
  • tests/unit/mock.py
  • tests/unit/mock_runner_managers.py
  • tests/unit/test_charm.py
  • tests/unit/test_charm_state.py
  • tests/unit/test_event_timer.py
  • tests/unit/test_firewall.py
  • tests/unit/test_logrotate.py
  • tests/unit/test_lxd_runner_manager.py
  • tests/unit/test_runner.py
  • tests/unit/test_runner_scaler.py
  • tests/unit/test_shared_fs.py
  • tests/unit/test_utilities.py
  • tox.ini
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

Lint checks failed for 0c61854

```

tests/integration/conftest.py:576: error: Item "Type" of "Type | None" has no attribute "units" [union-attr]
tests/integration/conftest.py:576: error: Item "None" of "Type | None" has no attribute "units" [union-attr]
Found 2 errors in 1 file (checked 57 source files)

Copy link
Contributor

Test coverage for 0c61854

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
src/charm.py                   655    150    140     27    74%   254-256, 322-341, 359-361, 362->366, 392-396, 470-472, 481, 488-490, 511-516, 533-538, 559, 571-577, 592-593, 612-613, 622, 627, 657-658, 660->669, 664->669, 674-681, 715, 719-724, 776, 788->791, 814-826, 830-831, 864-865, 877-894, 918-920, 939-949, 1029-1030, 1032-1033, 1035-1036, 1115->1117, 1182-1183, 1221-1223, 1231-1239, 1315-1348, 1362-1367, 1382-1425, 1433-1434, 1456
src/charm_state.py             450     17     82      3    95%   274-286, 505-509, 631-632, 687-688, 1123->1126, 1130-1131, 1178
src/errors.py                   25      0      0      0   100%
src/event_timer.py              52      6      0      0    88%   105-106, 143-144, 160-161
src/firewall.py                 51     18     10      0    67%   42-43, 66-69, 111-185
src/github_client.py            23      2      4      0    93%   71-72
src/logrotate.py                43      0      2      0   100%
src/lxd_type.py                 35      0      0      0   100%
src/runner_manager_type.py      39      0      0      0   100%
src/runner_type.py              38      0      0      0   100%
src/shared_fs.py                98     17     10      1    83%   60-61, 132-133, 162-163, 171-172, 178-179, 210, 213-214, 226-227, 270-271
src/utilities.py                32      4      6      2    79%   66-69, 111
------------------------------------------------------------------------
TOTAL                         1541    214    254     33    84%

Static code analysis report

Run started:2025-01-15 06:47:54.984967

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5084
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 6

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant