Retrieve SMTP config from SMTP integrator

[arturo-seijas]

Applicable spec: N/A

Overview

Retrieve SMTP config from SMTP integrator

Rationale

Leverage the new SMTP integrator charm

Juju Events Changes

Module Changes

• New smtp observer module
• Changes in state
• Changes in charm

Library Changes

• Added smtp lib

Checklist

• The charm style guide was applied
• The contributing guide was applied
• The changes are compliant with ISD054 - Managing Charm Complexity
• The documentation is generated using src-docs
• The documentation for charmhub is updated
• The PR is tagged with appropriate label (urgent, trivial, complex)

[amandahla]

One last question: Is SMTP required by Indico? Should be added to _are_relations_ready?

[arturo-seijas]

One last question: Is SMTP required by Indico? Should be added to _are_relations_ready?

Indico can work without an SMTP server

[amandahla]

LGTM

[yanksyoon]

LGTM, I do think that emitting config_changed event should be refactored as soon as it can be :p

[github-actions]

Test coverage for ff3d1df

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 325      8     82      9    96%   481->exit, 528->531, 624->663, 709, 769-770, 852->868, 854->863, 863->868, 876-877, 925->exit, 963-969
src/database_observer.py      33      0      4      0   100%
src/smtp_observer.py          16      0      0      0   100%
src/state.py                  44      0      4      0   100%
----------------------------------------------------------------------
TOTAL                        418      8     90      9    97%

Static code analysis report

Run started:2023-11-08 12:14:19.410061

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2461
  Total lines skipped (#nosec): 7
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

[gregory-schiano]

LGTM

[amandahla]

LGTM