Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redeployment documentation #390

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Add redeployment documentation #390

merged 5 commits into from
Apr 30, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Apr 30, 2024

Applicable spec:
N/A

Overview

Add redeployment documentation

Rationale

N/A

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@arturo-seijas arturo-seijas requested a review from a team as a code owner April 30, 2024 10:55
docs/how-to/redeploy.md Outdated Show resolved Hide resolved
docs/how-to/redeploy.md Outdated Show resolved Hide resolved
arturo-seijas and others added 2 commits April 30, 2024 13:10
Co-authored-by: Christopher Bartz <[email protected]>
Co-authored-by: Christopher Bartz <[email protected]>
@arturo-seijas arturo-seijas requested a review from cbartz April 30, 2024 11:10
cbartz
cbartz previously approved these changes Apr 30, 2024
Copy link
Contributor

Test coverage for ff9505a

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 323      9     82      7    96%   605, 646-647, 735->751, 737->746, 746->751, 759-760, 799, 832->exit, 870-876
src/database_observer.py      33      0      4      0   100%
src/s3_observer.py            18      0      0      0   100%
src/saml_observer.py          15      0      0      0   100%
src/smtp_observer.py          16      0      0      0   100%
src/state.py                  74      0     10      0   100%
----------------------------------------------------------------------
TOTAL                        479      9     96      7    97%

Static code analysis report

Run started:2024-04-30 11:25:16.889176

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2885
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

yanksyoon
yanksyoon previously approved these changes Apr 30, 2024
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions, thank you!

docs/how-to/redeploy.md Outdated Show resolved Hide resolved
docs/how-to/redeploy.md Show resolved Hide resolved
@arturo-seijas arturo-seijas dismissed stale reviews from yanksyoon and cbartz via 0f962ab April 30, 2024 13:29
yanksyoon
yanksyoon previously approved these changes Apr 30, 2024
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Christopher Bartz <[email protected]>
@arturo-seijas arturo-seijas requested a review from yanksyoon April 30, 2024 13:32
@arturo-seijas arturo-seijas merged commit 31b1f86 into main Apr 30, 2024
20 of 25 checks passed
@arturo-seijas arturo-seijas deleted the redeployment-docs branch April 30, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants