Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging configuration #404

Closed
wants to merge 5 commits into from
Closed

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented May 28, 2024

Applicable spec:

Overview

Follow up #402

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@arturo-seijas arturo-seijas requested a review from a team as a code owner May 28, 2024 08:35
@arturo-seijas arturo-seijas changed the title Improve logging Improve logging configuration May 28, 2024
cbartz
cbartz previously approved these changes May 28, 2024
cbartz
cbartz previously approved these changes May 28, 2024
mthaddon
mthaddon previously approved these changes May 28, 2024
@arturo-seijas arturo-seijas dismissed stale reviews from cbartz and mthaddon via 2cf815c May 29, 2024 10:31
Copy link
Contributor

Test coverage for 4b2774a

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 319      9     82      7    96%   597, 638-639, 727->743, 729->738, 738->743, 751-752, 791, 824->exit, 862-868
src/database_observer.py      32      0      4      0   100%
src/s3_observer.py            17      0      0      0   100%
src/saml_observer.py          14      0      0      0   100%
src/smtp_observer.py          15      0      0      0   100%
src/state.py                  73      0     10      0   100%
----------------------------------------------------------------------
TOTAL                        470      9     96      7    97%

Static code analysis report

Run started:2024-05-29 16:48:01.234342

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2885
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01
Copy link
Contributor

Spoke with Arturo, and it appears that some of the changes in this pull request will be superseeded by the updates in #406. As a result, I will be closing this pull request.

@weiiwang01 weiiwang01 closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants