Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Indico Rock to Ubuntu 24.04 #437

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Updated Indico Rock to Ubuntu 24.04 #437

merged 5 commits into from
Aug 8, 2024

Conversation

alithethird
Copy link
Contributor

Updated Indico Rock to Ubuntu 24.04

Overview

Made changes to rockcraft.yaml file to use base Ubuntu 24.04

Rationale

After Indico 3.3 update Python 3.12 was needed and we did that with deadsnake repo but a better way is to use the Ubuntu version that comes with Python 3.12 which is Ubuntu 24.04

Juju Events Changes

Module Changes

Library Changes

Checklist

@alithethird alithethird added good first issue Good for newcomers trivial labels Aug 6, 2024
@alithethird alithethird requested a review from a team as a code owner August 6, 2024 10:58
arturo-seijas
arturo-seijas previously approved these changes Aug 6, 2024
weiiwang01
weiiwang01 previously approved these changes Aug 6, 2024
@alithethird alithethird dismissed stale reviews from weiiwang01 and arturo-seijas via 14838e3 August 6, 2024 11:18
nrobinaubertin
nrobinaubertin previously approved these changes Aug 6, 2024
@alithethird alithethird requested a review from weiiwang01 August 6, 2024 11:25
src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Test coverage for 8c19684

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 331      9     80      7    96%   630, 671-672, 763->779, 765->774, 774->779, 787-788, 827, 860->exit, 898-904
src/database_observer.py      32      0      4      0   100%
src/s3_observer.py            17      0      0      0   100%
src/saml_observer.py          14      0      0      0   100%
src/smtp_observer.py          15      0      0      0   100%
src/state.py                  73      0     10      0   100%
----------------------------------------------------------------------
TOTAL                        482      9     94      7    97%

Static code analysis report

Run started:2024-08-07 16:00:51.991247

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2984
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@alithethird alithethird merged commit 7516278 into main Aug 8, 2024
24 checks passed
@alithethird alithethird deleted the indico-rock-noble branch August 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants