Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(nginx-rock): Update the rock base, websockets version pin. #466

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

alithethird
Copy link
Contributor

@alithethird alithethird commented Nov 18, 2024

Updated the indico-nginx-rock base, updated the nginx-prometheus-exporter from a snap to source. Pinned the websockets version.

Overview

Rationale

indico-nginx-rock base should have been updated when indico-rock base was updated so fixing that now.
nginx-prometheus-exporter snap was using old golang and that had some security issues.
websockets needs to be pinned.

Juju Events Changes

Module Changes

Library Changes

Checklist

@alithethird alithethird added the enhancement New feature or request label Nov 18, 2024
@alithethird alithethird requested a review from a team as a code owner November 18, 2024 11:43
yanksyoon
yanksyoon previously approved these changes Nov 19, 2024
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments :)

.trivyignore Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Co-authored-by: Yanks Yoon <[email protected]>
tox.ini Show resolved Hide resolved
Copy link
Contributor

Test coverage for d367545

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 349     12     80      8    95%   404, 418-419, 669, 710-711, 802->818, 804->813, 813->818, 826-827, 866, 899->exit, 937-943
src/database_observer.py      32      0      4      0   100%
src/s3_observer.py            17      0      0      0   100%
src/saml_observer.py          14      0      0      0   100%
src/smtp_observer.py          15      0      0      0   100%
src/state.py                  73      0      8      0   100%
----------------------------------------------------------------------
TOTAL                        500     12     92      8    97%

Static code analysis report

Run started:2024-11-20 05:53:32.333975

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3113
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@alithethird alithethird merged commit 4a506e2 into main Nov 22, 2024
24 checks passed
@alithethird alithethird deleted the nginx-rock-update branch November 22, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants