o/snapstate: add some metadata to help with component remodeling #14939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14939 +/- ##
=========================================
Coverage ? 78.27%
=========================================
Files ? 1157
Lines ? 153506
Branches ? 0
=========================================
Hits ? 120161
Misses ? 25940
Partials ? 7405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thu Jan 23 21:54:02 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
pedronis
reviewed
Jan 17, 2025
overlord/snapstate/snapmgr.go
Outdated
|
|
||
| // ComponentExclusiveSetup is set if this SnapSetup exists only to deal with | ||
| // components, and not the snap itself. | ||
| ComponentExclusiveSetup bool `json:"component-exclusive-setup,omitempty"` |
There was a problem hiding this comment.
shouldn't we s/Setup/Operation/ ? the snap setup still describes a snap but the operation it is involved with touches only components? can you point in the description of this where this is going to be consulted in the larger PR?
There was a problem hiding this comment.
Pointed to it here: https://github.com/canonical/snapd/pull/14933/files#r1920313619
andrewphelpsj
force-pushed
the
add-metadata-for-component-remodel
branch
from
9173c13 to
585ee25
Compare
…mponent-setup when installing a snap with components This indicates to ifacestate's setup-profiles handler that the setup-profiles should operate on a snap and a set of components, rather than a single component.
…s only associated with components or not
…used to create a recovery system
andrewphelpsj
force-pushed
the
add-metadata-for-component-remodel
branch
from
585ee25 to
92729a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a field to SnapSetup for tracking if a SnapSetup comes from a task set that only deals with components.
Additionally, this adds an edge that points to the snap setup task that is created by many of the functions in snapstate. Since a task set might contain many snap-setup tasks, but we really only want to find one (especially now that a snap-setup task needs to carry a
component-setup-tasks), we use this edge to pick the one that will have all the fields needed to help with remodeling.