docs: Fix snapcraft build instructions and explicitly install lxd #14941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requisite The current documentation for building snapd with snapcraft doesn't work in 24.04. It also doesn't mention the LXD requirement, which leads to uncertainty about the build process when lxd asks many config questions and isn't mentioned in the build instructions. This documentation change: - Adds --classic flag to snap install for snapcraft, as it is required - Removes --channel option from snapcraft call as it no longer exists in 8.5.1 - Adds necessary and missing sudo to snap install - Makes the lxd install and lxd init step explicit
|
Fri Jan 17 08:24:38 UTC 2025 Spread tests skipped |
|
I believe I have signed the contributor agreement for my GitHub user wheelerz, but it was only a few hours ago so I believe it has not gone through yet. |
wheelerz
force-pushed
the
fix-hacking-doc
branch
from
12d0b61 to
c3d5585
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14941 +/- ##
=========================================
Coverage ? 78.04%
=========================================
Files ? 1140
Lines ? 152415
Branches ? 0
=========================================
Hits ? 118958
Misses ? 26118
Partials ? 7339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running through a build using current documentation in HACKING.md for building snapd with snapcraft and it doesn't work in 24.04 (or 22.04). It also doesn't mention the lxd requirement, which leads to uncertainty about the build process when lxd asks many config questions and isn't mentioned in the build instructions. This documentation change: