Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition integ tests #194

Merged
merged 48 commits into from
Feb 16, 2024
Merged

Partition integ tests #194

merged 48 commits into from
Feb 16, 2024

Conversation

nrobinaubertin
Copy link
Contributor

@nrobinaubertin nrobinaubertin commented Feb 9, 2024

Overview

This PR splits the integration tests in multiple modules to execute them in parallel. This will speed up the CI and allow for targeted retries if need be.

Checklist

@nrobinaubertin nrobinaubertin requested a review from a team as a code owner February 10, 2024 00:54
tests/integration/test_charm.py Show resolved Hide resolved
tests/integration/test_nginx.py Outdated Show resolved Hide resolved
tests/integration/test_cos.py Outdated Show resolved Hide resolved
amandahla
amandahla previously approved these changes Feb 16, 2024
Copy link
Collaborator

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM \o/

Copy link
Contributor

Test coverage for 04bb364

Name                            Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------
src/actions/__init__.py             3      0      0      0   100%
src/actions/register_user.py       22      0      2      0   100%
src/actions/reset_instance.py      21      0      2      0   100%
src/admin_access_token.py          48     32     12      0    27%   52-92
src/backup.py                     197      5     30      2    97%   404-405, 474-475, 531->533, 534
src/backup_observer.py            133     16     14      0    89%   130-133, 138-141, 177-180, 209-212
src/charm.py                      180      4     36      1    98%   162-163, 226-227
src/charm_state.py                 63      1     10      1    97%   127
src/charm_types.py                 23      0      6      0   100%
src/database_client.py             53      1     10      3    94%   35, 47->exit, 69->exit
src/database_observer.py           48      4      4      0    92%   69-71, 87
src/exceptions.py                   4      1      0      0    75%   22
src/mjolnir.py                     84     12     24      2    83%   64-72, 81, 173-174
src/observability.py                9      0      0      0   100%
src/pebble.py                     102     12     16      6    85%   95-96, 98-99, 107, 109, 111, 115, 136-137, 152-153
src/saml_observer.py               45      1      8      0    98%   64
src/smtp_observer.py               70      3     14      1    95%   70-74, 96->101
src/synapse/__init__.py             4      0      0      0   100%
src/synapse/admin.py               20      9      2      0    50%   40-41, 63-74
src/synapse/api.py                161      2     22      2    98%   207, 376
src/synapse/workload.py           279      8     44      6    96%   425->exit, 454-455, 507-508, 544-545, 561, 610->613, 659, 667->669, 669->671
src/user.py                        24      0      4      0   100%
---------------------------------------------------------------------------
TOTAL                            1593    111    260     24    92%

Static code analysis report

Run started:2024-02-16 14:36:08.320306

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 8423
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@nrobinaubertin nrobinaubertin merged commit 47e0ab9 into main Feb 16, 2024
24 checks passed
@nrobinaubertin nrobinaubertin deleted the partition-integ-tests branch February 16, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants