-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add matrix-auth integration #565
Conversation
Integration test failing due |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely commented code! LGTM w minor nits :)
Co-authored-by: Yanks Yoon <[email protected]>
6521111
Co-authored-by: Yanks Yoon <[email protected]>
Test coverage for deaccd5
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick changes!
Overview
Add matrix-auth integration.
Note:
Twisted version is pinned due to this issue:
element-hq/synapse#17882
Todo
Rationale
Integrate Synapse with plugins and application services
Juju Events Changes
Matrix auth relation changed and departed.
Why not matrix_auth_request_processed?
The
on = RedisRelationCharmEvents()
prevents that. :-(Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)