generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance .drafts
properties with draft table properties
#354
Merged
daogrady
merged 11 commits into
cap-js:main
from
stockbal:feat/dedicated-draft-entities
Oct 24, 2024
Merged
feat: enhance .drafts
properties with draft table properties
#354
daogrady
merged 11 commits into
cap-js:main
from
stockbal:feat/dedicated-draft-entities
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daogrady
reviewed
Oct 17, 2024
daogrady
reviewed
Oct 24, 2024
stockbal
changed the title
feat: create dedicated draft classes for draft enabled entities
feat: enhance Oct 24, 2024
.drafts
properties with draft properties
stockbal
changed the title
feat: enhance
feat: enhance Oct 24, 2024
.drafts
properties with draft properties.drafts
properties with draft table properties
daogrady
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for yet another cool contribution! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @daogrady,
this is a proposal for enhancing the type behind the
.drafts
property of draft enabled classes, to include the additional fields that will be generated for draft tables.At the same time it would also overwork
.drafts
at the plural entity, to use an enhanced version of the generated plural class of an entity, so fixes #163.P.S.: tests do not yet exist. I will create them if you think we can go ahead with this approach
Tasks
Sample
Generated classes
Explanation about types
The type
DraftEntity<T>
is exported so users can type their variables or parameters to a draft entitySide note
Fixes auto-closed issue #100