use constants with miningful names instead of oidIdParts[N]

cap-js · Dec 10, 2024 · 1218ec6 · 1218ec6
1 parent 0135366
commit 1218ec6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/templates.js b/lib/templates.js
@@ -80,9 +80,11 @@ const createEntityTypeMappingsItemTemplate = (entity) => {
         }
     } else if (entity[ENTITY_RELATIONSHIP_ANNOTATION]) {
         const ordIdParts = entity[ENTITY_RELATIONSHIP_ANNOTATION].split(":");
+        const namespace = ordIdParts[0];
         const entityName = ordIdParts[1];
+        const version = ordIdParts[2] || "v1";
         return {
-            ordId: `${ordIdParts[0]}:entityType:${entityName}:${ordIdParts[2] || "v1"}`,
+            ordId: `${namespace}:entityType:${entityName}:${version}`,
             entityName,
             ...entity
         };