[fcm] allow empty token

capcom6 · Jan 6, 2025 · 755f353 · 755f353
1 parent fc991b2
commit 755f353
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/app/src/main/java/me/capcom/smsgateway/modules/gateway/GatewayService.kt b/app/src/main/java/me/capcom/smsgateway/modules/gateway/GatewayService.kt
@@ -117,7 +117,7 @@ class GatewayService(
         )
     }
 
-    internal suspend fun registerFcmToken(pushToken: String) {
+    internal suspend fun registerFcmToken(pushToken: String?) {
         if (!settings.enabled) return
 
         val settings = settings.registrationInfo
@@ -126,13 +126,15 @@ class GatewayService(
         if (accessToken != null) {
             // if there's an access token, try to update push token
             try {
-                api.devicePatch(
-                    accessToken,
-                    GatewayApi.DevicePatchRequest(
-                        settings.id,
-                        pushToken
+                pushToken?.let {
+                    api.devicePatch(
+                        accessToken,
+                        GatewayApi.DevicePatchRequest(
+                            settings.id,
+                            it
+                        )
                     )
-                )
+                }
                 events.emit(
                     DeviceRegisteredEvent(
                         api.hostname,

diff --git a/app/src/main/java/me/capcom/smsgateway/modules/gateway/workers/RegistrationWorker.kt b/app/src/main/java/me/capcom/smsgateway/modules/gateway/workers/RegistrationWorker.kt
@@ -26,7 +26,7 @@ class RegistrationWorker(
 
     override suspend fun doWork(): Result {
         try {
-            val token = inputData.getString(DATA_TOKEN) ?: return Result.failure()
+            val token = inputData.getString(DATA_TOKEN)
 
             App.instance.gatewayService.registerFcmToken(token)
 

diff --git a/app/src/main/java/me/capcom/smsgateway/services/PushService.kt b/app/src/main/java/me/capcom/smsgateway/services/PushService.kt
@@ -80,7 +80,7 @@ class PushService : FirebaseMessagingService(), KoinComponent {
                 message = "FCM registration started"
             )
             FirebaseMessaging.getInstance().token.addOnCompleteListener(OnCompleteListener { task ->
-                if (!task.isSuccessful) {
+                if (!task.isSuccessful || task.isCanceled) {
                     Toast.makeText(
                         context,
                         "Fetching FCM registration token failed: ${task.exception}",
@@ -91,7 +91,6 @@ class PushService : FirebaseMessagingService(), KoinComponent {
                         module = PushService::class.java.simpleName,
                         message = "Fetching FCM registration token failed: ${task.exception}"
                     )
-                    return@OnCompleteListener
                 }
 
                 // Get new FCM registration token