Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combo-box): ai-label with close style #18432

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

Closes #18392

before (overlapping AILabel and Close)
Screenshot 2025-01-24 at 10 40 18 AM

after (spaced out evenly)
Screenshot 2025-01-24 at 10 40 29 AM

Changelog

Changed

  • update styles to look for inner wrapper first then ai-label. remove duplicate styles

Testing / Reviewing

confirm combobox ai-label is styled correctly
make sure other list-box components aren't effected with ai-label styles

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 4b242d6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6793e5d363608a000839443d
😎 Deploy Preview https://deploy-preview-18432--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4b242d6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6793e5d3c48a7f0008d84371
😎 Deploy Preview https://deploy-preview-18432--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4b242d6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6793e5d3b406130008ec55d4
😎 Deploy Preview https://deploy-preview-18432--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (eee39f8) to head (4b242d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18432   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files         408      408           
  Lines       14443    14443           
  Branches     4641     4691   +50     
=======================================
  Hits        12155    12155           
+ Misses       2124     2123    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ComboBox decorator overlaps with "X" button to cancel out the current selection
1 participant