-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/upstream new mp spdz #63
Feature/upstream new mp spdz #63
Conversation
Signed-off-by: Timo Klenk <[email protected]>
Signed-off-by: Timo Klenk <[email protected]>
c4b9509
to
494e343
Compare
Signed-off-by: Timo Klenk <[email protected]>
Should be ready to review. Do we need another setup test, or is it fine with the above being done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be ready for being merge after resolving one small finding.
docs/getting-started/deployment.md
Outdated
curl -O -L https://github.com/carbynestack/base-images/raw/3595c5427915b2f9e1f22804e3f742cda9e72312/fake-crypto-material.zip | ||
unzip -d crypto-material fake-crypto-material.zip | ||
rm fake-crypto-material.zip | ||
curl -O -L https://github.com/carbynestack/carbynestack/raw/master/tuples/fake-crypto-material-0.2.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace master
with a concrete commit sha to lower the risk of breaking the tutorial when updating master
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Timo Klenk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow-up on (needs all those merged first, hence still a draft PR atm)
Closes