Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upstream new mp spdz #63

Merged
merged 4 commits into from
May 17, 2022

Conversation

kindlich
Copy link
Contributor

kindlich added 2 commits May 13, 2022 18:47
Signed-off-by: Timo Klenk <[email protected]>
Signed-off-by: Timo Klenk <[email protected]>
@kindlich kindlich force-pushed the feature/upstream-new-mp-spdz branch from c4b9509 to 494e343 Compare May 16, 2022 07:28
Signed-off-by: Timo Klenk <[email protected]>
@kindlich kindlich marked this pull request as ready for review May 17, 2022 08:11
@kindlich
Copy link
Contributor Author

Should be ready to review.
The general workflow (that the new tuples work and that the CLI works) were already tested here
carbynestack/carbynestack#37 (comment)

Do we need another setup test, or is it fine with the above being done?

Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be ready for being merge after resolving one small finding.

curl -O -L https://github.com/carbynestack/base-images/raw/3595c5427915b2f9e1f22804e3f742cda9e72312/fake-crypto-material.zip
unzip -d crypto-material fake-crypto-material.zip
rm fake-crypto-material.zip
curl -O -L https://github.com/carbynestack/carbynestack/raw/master/tuples/fake-crypto-material-0.2.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace master with a concrete commit sha to lower the risk of breaking the tutorial when updating master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Timo Klenk <[email protected]>
Copy link
Member

@strieflin strieflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strieflin strieflin merged commit 3836b06 into carbynestack:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants