Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xochitl edits to episode 4 #58

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Xochitl edits to episode 4 #58

merged 8 commits into from
Sep 25, 2024

Conversation

xortizross
Copy link
Contributor

Addresses mainly #19 and #47 for episode 4

Made changes to Episode 4: datasets to match the narrative and edited the examples to match.

Also changed some titles on some other docs

@xortizross xortizross added the episode:datasets Any issues related to episode 4. Minimal Reproducible Data label Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/R-help-reprexes/compare/md-outputs..md-outputs-PR-58

The following changes were observed in the rendered markdown documents:

 4-minimal-reproducible-data.md | 627 +++++++++++++++++++++++++++++------------
 CODE_OF_CONDUCT.md             |   4 +-
 LICENSE.md                     |   4 +-
 md5sum.txt                     |   6 +-
 4 files changed, 452 insertions(+), 189 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-25 20:50:07 +0000

github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
@peterlaurin
Copy link
Collaborator

Looks good to me!

@peterlaurin peterlaurin self-requested a review September 25, 2024 20:53
Copy link
Collaborator

@peterlaurin peterlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peterlaurin peterlaurin merged commit 444bbe5 into main Sep 25, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
Auto-generated via {sandpaper}
Source  : 444bbe5
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-09-25 20:54:42 +0000
Message : Merge pull request #58 from carpentries-incubator/xochitl_edits

Xochitl edits to episode 4 -- Sep 25th meeting
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
Auto-generated via {sandpaper}
Source  : f7948ce
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-25 20:55:28 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 444bbe5
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-09-25 20:54:42 +0000
Message : Merge pull request #58 from carpentries-incubator/xochitl_edits

Xochitl edits to episode 4 -- Sep 25th meeting
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
Auto-generated via {sandpaper}
Source  : f7948ce
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-25 20:55:28 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 444bbe5
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-09-25 20:54:42 +0000
Message : Merge pull request #58 from carpentries-incubator/xochitl_edits

Xochitl edits to episode 4 -- Sep 25th meeting
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Auto-generated via {sandpaper}
Source  : f7948ce
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-25 20:55:28 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 444bbe5
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-09-25 20:54:42 +0000
Message : Merge pull request #58 from carpentries-incubator/xochitl_edits

Xochitl edits to episode 4 -- Sep 25th meeting
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
Auto-generated via {sandpaper}
Source  : f7948ce
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-25 20:55:28 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 444bbe5
Branch  : main
Author  : peterlaurin <[email protected]>
Time    : 2024-09-25 20:54:42 +0000
Message : Merge pull request #58 from carpentries-incubator/xochitl_edits

Xochitl edits to episode 4 -- Sep 25th meeting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
episode:datasets Any issues related to episode 4. Minimal Reproducible Data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants