Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Swift 6 toolchain support #211

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Improve Swift 6 toolchain support #211

merged 1 commit into from
Nov 5, 2024

Conversation

bradfol
Copy link
Collaborator

@bradfol bradfol commented Nov 5, 2024

No description provided.

@bradfol bradfol requested a review from skorulis-ap November 5, 2024 22:42
Package.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@skorulis-ap skorulis-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should bump to 6.0 yet, but the rest of the changes are good.

@bradfol
Copy link
Collaborator Author

bradfol commented Nov 5, 2024

I don't think we should bump to 6.0 yet

Yeah agreed, I'm moving the Package manifest toolchain version back to 5.10

@bradfol bradfol force-pushed the bradfol/swift6 branch 2 times, most recently from 1fc7831 to e413ae3 Compare November 5, 2024 23:24
@bradfol bradfol marked this pull request as ready for review November 5, 2024 23:27
@bradfol bradfol merged commit 98fa6a0 into main Nov 5, 2024
1 check passed
@bradfol bradfol deleted the bradfol/swift6 branch November 5, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants