Improve performance of DependencyBuilder #226
Conversation
skorulis-ap
force-pushed
the
skorulis/cast-performance
branch
from
c85f7c8 to
7307774
Compare
skorulis-ap
changed the title
skorulis-ap
changed the title
| @@ -97,3 +120,12 @@ public struct OverrideBehavior { | |||
| return NSClassFromString("XCTestCase") != nil | |||
| } | |||
| } | |||
|
|
|||
| public struct ModuleAssemblyFlags: OptionSet { | |||
| public let rawValue: Int | |||
There was a problem hiding this comment.
| public let rawValue: Int | |
| public let rawValue: UInt |
| @@ -40,6 +45,24 @@ public extension ModuleAssembly { | |||
| return self.resolverType == $0.resolverType | |||
| } | |||
| } | |||
|
|
|||
| static var _assemblyFlags: [ModuleAssemblyFlags] { | |||
There was a problem hiding this comment.
| static var _assemblyFlags: [ModuleAssemblyFlags] { | |
| static let _assemblyFlags: [ModuleAssemblyFlags] = { |
Can we make this a computed static property so it is only calculated once per assembly type?
There was a problem hiding this comment.
I can't add a static let in an extension
| if self is any AutoInitModuleAssembly.Type { | ||
| result.append(.autoInit) | ||
| } | ||
| if self is any AbstractAssembly.Type { |
There was a problem hiding this comment.
It seems like for these is checks we are just moving the call site? Is there some other way that this causes a performance improvement?
There was a problem hiding this comment.
This is the fallback, it only gets hit if a code gen version isn't available.
| static func _autoInstantiate() -> (any ModuleAssembly)? { | ||
| if let autoInit = self as? any AutoInitModuleAssembly.Type { | ||
| return autoInit.init() | ||
| } | ||
| return nil |
There was a problem hiding this comment.
| static func _autoInstantiate() -> (any ModuleAssembly)? { | |
| if let autoInit = self as? any AutoInitModuleAssembly.Type { | |
| return autoInit.init() | |
| } | |
| return nil | |
| static func _autoInstantiate() -> (any ModuleAssembly)? { | |
| return nil |
Should we remove the as? check here and always return nil?
There was a problem hiding this comment.
Or alternately remove the default extension implementation entirely?
There was a problem hiding this comment.
If I take out the default implementation then I'll have to add it manually for any test cases where it's not being autogenerated.
| let isAutoInit: Bool | ||
| if config.assemblyType == .abstractAssembly { | ||
| accessorBlock = AccessorBlockSyntax( | ||
| accessors: .getter(.init(stringLiteral: "[.autoInit, .abstract]")) |
There was a problem hiding this comment.
I don't see this case covered in the unit tests currently, mind adding a test case for it?
skorulis-ap
force-pushed
the
skorulis/cast-performance
branch
from
7307774 to
ad7da66
Compare
skorulis-ap
force-pushed
the
skorulis/cast-performance
branch
from
ad7da66 to
8c24c71
Compare
This removes the need for some casts like
if ref.type is any AbstractAssembly.Typewhich it turns out have a heavy performance penalty in large apps.This makes the code a little bit more complex but for a large app saves ~100ms in startup time.