Parse the TargetResolver from assemblies #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/target-resolver
branch
2 times, most recently
from
57250be to
4b84bf2
Compare
jmesmith
approved these changes
Nov 14, 2023
bradfol
approved these changes
Nov 14, 2023
|
|
||
| public init( | ||
| name: String, | ||
| registrations: [Registration], | ||
| registrationsIntoCollections: [RegistrationIntoCollection], | ||
| imports: [ImportDeclSyntax] = [] | ||
| imports: [ImportDeclSyntax] = [], | ||
| targetResolver: String = "Resolver" |
There was a problem hiding this comment.
Remove the default value here? (so it is not specified in multiple places)
Sources/KnitCommand/GenCommand.swift
Outdated
| var useTargetResolver: Bool = false | ||
|
|
||
| @Option(help: "Default type to extend when generating Resolver type safety methods") | ||
| var defaultExtensionTarget = "Resolver" |
There was a problem hiding this comment.
Maybe defaultExtensionTargetResolver to keep naming consistent
| self.targetResolver = identifier.name.text | ||
| } | ||
|
|
||
| return .skipChildren |
There was a problem hiding this comment.
Just as a curiosity I wonder if it is possible for TypeAliasDecl nodes to have child nodes 🤔
skorulis-ap
force-pushed
the
skorulis/target-resolver
branch
from
82ba97b to
b201b3d
Compare
bradfol
reviewed
Nov 15, 2023
| self.targetResolver = identifier.name.text | ||
| } | ||
|
|
||
| return .visitChildren |
There was a problem hiding this comment.
Oh sorry if my other comment was confusing, I think skip children is what we want here
skorulis-ap
force-pushed
the
skorulis/target-resolver
branch
from
b201b3d to
52a80a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks for instances of
typealias TargetResolver = Fooand generates type safe extensions underneath the targeted resolver.This allows correct scoping of generated type safety functions.
I added
useTargetResolveras a way to disable this functionality if we upgrade knit versions but aren't ready to make the switch.defaultExtensionTargetwas also added to allow correctly setting the resolver for assemblies which aren't explicitly defining a typealias.