feat: Use com.google.inject over javax.inject to allow migrate to guice7+
#2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to Guice 7 This replaces usages to enable migration to [Guice 7+](https://github.com/google/guice/wiki/Guice700). This is the first (only?) step to allow projects using Guice 6.0.0 *or* Guice 7.0.0 to use `misk-inject`. By using `com.google.inject` instead of `javax.inject`, injections work in both 6+ and 7+ versions. The new project, `:misk-inject-guice7-test` sets up a test project with the classpath forced to Guice 7+. This acts as a guard project for basic usages. As needed, we can add more content.
Nava2
commented
Jul 24, 2023
| @@ -0,0 +1,5 @@ | |||
| ## misk-inject-guice7-test | |||
There was a problem hiding this comment.
These files are the only not-renaming-import changes
Nava2
commented
Jul 24, 2023
| @@ -0,0 +1,23 @@ | |||
|
|
|||
| plugins { | |||
There was a problem hiding this comment.
These files are the only not-renaming-import changes
| import org.junit.jupiter.api.BeforeEach | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| internal class Guice7IntegrationTest { |
There was a problem hiding this comment.
These files are the only not-renaming-import changes
| import org.assertj.core.api.Assertions.assertThat | ||
|
|
||
| @Singleton | ||
| internal class Guice7TestClass @Inject constructor( |
There was a problem hiding this comment.
These files are the only not-renaming-import changes
| @@ -0,0 +1,5 @@ | |||
| package misk.inject.guice7 | |||
|
|
|||
| internal interface Guice7TestInterface { | |||
There was a problem hiding this comment.
These files are the only not-renaming-import changes
Nava2
changed the title
com.google.inject over javax.inject to allow migrat…com.google.inject over javax.inject to allow migrate to guice7+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: #2863
This replaces usages to enable migration to Guice 7+. This is the first (only?) step to allow projects using Guice 6.0.0 or Guice 7.0.0 to use
misk-inject.By using
com.google.injectinstead ofjavax.inject, injections work in both 6+ and 7+ versions. The new project,:misk-inject-guice7-testsets up a test project with the classpath forced to Guice 7+. This acts as a guard project for basic usages. As needed, we can add more content.