Switch from ssl.wrap_socket to SSLContext.wrap_socket #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python docs specify that since python 3.2, it is recommended to use
`SSLContext.wrap_socket` instead of `ssl.wrap_socket` ("since it is both
inefficient and has no support for SNI and hostname matching").
In python3.12, `ssl.wrap_socket` was removed, which causes the 100-continue
test to reliably fail whenever it's configured with `is_secure=True`.
Switching to the recommended `SSLContext.wrap_socket` (using the default
SSL context) fixes this, allowing the test to run cleanly again.
Signed-off-by: Jacques Heunis <[email protected]>
adamemerson
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python docs specify that since python 3.2, it is recommended to use
SSLContext.wrap_socketinstead ofssl.wrap_socket("since it is both inefficient and has no support for SNI and hostname matching").In python3.12,
ssl.wrap_socketwas removed, which causes the 100-continue test to reliably fail whenever it's configured withis_secure=True. Switching to the recommendedSSLContext.wrap_socket(using the default SSL context) fixes this, allowing the test to run cleanly again.