Skip to content

Commit

Permalink
fix: update recon test expectations (and typo)
Browse files Browse the repository at this point in the history
we need to figure out how to make these deterministic. currently they exact order of exchange depends on the speed at which the other side takes certain actions. speeding up the inserts appears to have caused a resp before a second req in some cases.
  • Loading branch information
dav1do committed Jan 24, 2024
1 parent 5ca7e4b commit 88aac7b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion recon/src/recon.rs
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ where
self.store.value_for_key(&key).await
}

/// Insert many keys into the key space. Includes an optional value.
/// Insert key into the key space. Includes an optional value.
/// Returns a boolean (true) indicating if the key was new.
pub async fn insert(&mut self, item: ReconItem<'_, K>) -> Result<bool> {
let new_val = item.value.is_some();
Expand Down
20 changes: 10 additions & 10 deletions recon/src/recon/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1302,10 +1302,10 @@ async fn disjoint() {
cat: [a: A, b: B, c: C, e: , f: , g: ]
-> value_req(e)
cat: [a: A, b: B, c: C, e: , f: , g: ]
<- value_resp(e: E)
dog: [a: A, b: B, c: C, e: E, f: F, g: G]
-> value_req(f)
cat: [a: A, b: B, c: C, e: , f: , g: ]
<- value_resp(e: E)
dog: [a: A, b: B, c: C, e: E, f: F, g: G]
-> value_req(g)
cat: [a: A, b: B, c: C, e: E, f: , g: ]
<- value_resp(f: F)
Expand Down Expand Up @@ -1482,10 +1482,10 @@ async fn paper() {
cat: [ape: APE, bee: BEE, cot: COT, doe: , eel: EEL, fox: FOX, gnu: GNU]
<- range_resp({gnu h(hog)#1 𝛀 })
dog: [ape: APE, bee: BEE, cot: COT, doe: DOE, eel: EEL, fox: FOX, gnu: GNU, hog: HOG]
-> listen_only
cat: [ape: APE, bee: BEE, cot: COT, doe: , eel: EEL, fox: FOX, gnu: GNU, hog: HOG]
<- value_resp(doe: DOE)
dog: [ape: APE, bee: BEE, cot: COT, doe: DOE, eel: EEL, fox: FOX, gnu: GNU, hog: HOG]
-> listen_only
cat: [ape: APE, bee: BEE, cot: COT, doe: , eel: EEL, fox: FOX, gnu: GNU, hog: HOG]
<- listen_only
dog: [ape: APE, bee: BEE, cot: COT, doe: DOE, eel: EEL, fox: FOX, gnu: GNU, hog: HOG]
-> finished
Expand Down Expand Up @@ -1729,18 +1729,18 @@ async fn alternating() {
cat: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: , v: V, w: , x: X, y: , z: Z]
-> value_req(u)
cat: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: , v: V, w: , x: X, y: , z: Z]
<- value_resp(u: U)
dog: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: W, x: X, y: Y, z: Z]
-> value_req(w)
cat: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: , v: V, w: , x: X, y: , z: Z]
<- value_resp(u: U)
<- value_resp(w: W)
dog: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: W, x: X, y: Y, z: Z]
-> value_req(y)
cat: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: , x: X, y: , z: Z]
<- value_resp(w: W)
<- value_resp(y: Y)
dog: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: W, x: X, y: Y, z: Z]
-> listen_only
cat: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: W, x: X, y: , z: Z]
<- value_resp(y: Y)
dog: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: W, x: X, y: Y, z: Z]
<- listen_only
dog: [a: A, b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, o: O, p: P, q: Q, r: R, s: S, t: T, u: U, v: V, w: W, x: X, y: Y, z: Z]
-> finished
Expand Down Expand Up @@ -1959,10 +1959,10 @@ async fn subset_interest() {
dog: [b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, r: ]
-> value_req(i)
cat: [b: , c: C, e: , f: F, g: G, i: , m: , n: N, r: R]
-> value_req(m)
cat: [b: , c: C, d: D, e: , f: F, g: G, i: , m: , n: N, r: R]
<- range_resp({c h(d)#1 e})
dog: [b: B, c: C, d: D, e: E, f: F, g: G, h: H, i: I, j: J, k: K, l: L, m: M, n: N, r: ]
-> value_req(m)
cat: [b: , c: C, d: D, e: , f: F, g: G, i: , m: , n: N, r: R]
-> value_resp(r: R)
cat: [b: , c: C, d: D, e: , f: F, g: G, i: , m: , n: N, r: R]
<- range_resp({e 0 f})
Expand Down

0 comments on commit 88aac7b

Please sign in to comment.