Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add simpler shutdown handling #643

Merged
merged 4 commits into from
Jan 14, 2025
Merged

refactor: add simpler shutdown handling #643

merged 4 commits into from
Jan 14, 2025

Conversation

nathanielc
Copy link
Collaborator

This change adds a shutdown crate that simplifies shutdown handling. The API removes the need to create as many async move blocks and clone broadcast channels.

The older version of built does not understand new Cargo.lock files.
@nathanielc nathanielc requested review from stbrody, a team and dav1do as code owners January 14, 2025 18:56
@nathanielc nathanielc requested review from 3benbox and removed request for a team January 14, 2025 18:56
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :shipit:

This change adds a shutdown crate that simplifies shutdown handling. The
API removes the need to create as many async move blocks and clone
broadcast channels.
Base automatically changed from fix/clippy to main January 14, 2025 21:12
@nathanielc nathanielc added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 5bca7b5 Jan 14, 2025
6 checks passed
@nathanielc nathanielc deleted the feat/shutdown branch January 14, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants