New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS 2017 optimize #244

Closed

danaalsharif wants to merge 58 commits into cernopendata:cms-2016-sim-test from d0leh:cms-2017-optimize

Member

danaalsharif commented Aug 2, 2024

Created create_parent_dicts.py to initialize NANO-MINI map.
Integrated parent_dicts.py in dataset_records.py and mcm_store.py.
Modified scripts to allow user to choose number of threads through CLI option --threads.
Updated interface.py to integrate all other scripts and modifications.
Updated README.md.

Co-authored by @d0leh

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/README.md Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/config_store.py Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/create_parent_dicts.py Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/interface.py Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/mcm_store.py Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/tar_check Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/dataset_records.py Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/dataset_records.py Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/dataset_records.py Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/dataset_records.py Outdated Show resolved Hide resolved

katilp reviewed

View reviewed changes

cms-2017-simulated-datasets/code/dataset_records.py Outdated Show resolved Hide resolved

danaalsharif and others added 19 commits

September 9, 2024 18:31


          Modified .py files for 2017 data curation scripts

4b68b06


          Modified lhe_generators.py to make a subdirectory for each 1k entries.

c882a67


          Create cms-2017-simulated-datsets

c0e6d3a


          Delete cms-2017-simulated-datasets/n

51a1115


          Create n

d62926f


          added cms-2017.txt and recid_info.py

6c655df


          Update and rename recid_info (1).py to recid_info.py

834477c


          changes over codes and inputs for 2017 datasets.

4d9594f

co-author: @danaalsharif


          Built 198 sample datasets of 2017. Ran all the scripts successfully a…

cd1011d

…nd produced the results.

Co-author: @danaalsharif


          Delete cms-2017-simulated-datasets/cookies.txt

994930b


          Delete cms-2017-simulated-datasets/records.json

a3cfadb


          Delete cms-2017-simulated-datasets/outputs directory

ca66115


          Delete cms-2017-simulated-datasets/lhe_generators directory

953f961


          Delete cms-2017-simulated-datasets/inputs/config-store directory

0b1124a


          Delete cms-2017-simulated-datasets/inputs/mcm-store directory

da57ff7


          Delete cms-2017-simulated-datasets/inputs/das-json-store directory

e016487


          Update README.md

0f7a053


          Update README.md

633f307

fixed a typo


          Update README.md

e0e5217

d0leh and others added 25 commits

September 9, 2024 18:31


          Modified interface.py to warn the user if number of threads is not 20…

… in lhe step.

Co-author: @danaalsharif


          Modified .gitignore

4aed9af


          Fixed input file name in lhe_generators.py

ba77ba0


          Update README.md

772b87b


          Update interface.py

2d16530


          Update README.md

d304ffb


          Update README.md

23efd83


          Update README.md

4ceb86c


          Update config_store.py

5d1cdc7


          Modified config_store.py

4a01f5c


          Modified create_parent_dicts.py to print a warning in case of /AODSIM…

464fce4

… file found


          Update interface.py

a386d19


          Modified mcm_store.py

47790c5


          Update dataset_records.py

e0c6f13


          Removed unused functions in .py scripts

951ebb5


          Removed comments

4f813b8


          Removed comments in lhe_generators.py

8080e46


          Modified lhe_generators.py to print another warning for tar file errors.

9fc3730


          Update README.md

2ab1742


          Removed unused variable

423f095


          Delete cms-2017-simulated-datasets/output.txt

4e3e4e2


          Modified dataset_records.py to run get_all_generator_text only once f…

7f3dab2

…or both mini and nano.

co-author: @danaalsharif


          Added 2017 pileup file

952245e


          Modified dataset_records.py to run get_all_generator_text only once f…

8b3f3e2

…or both mini and nano.

co-author: @danaalsharif


          Added pileup file for 2017

dd9ff7a

tiborsimko force-pushed the cms-2016-sim-test branch from 4397736 to 0878405 Compare

September 9, 2024 16:33

tiborsimko force-pushed the cms-2017-optimize branch from f595a77 to dd9ff7a Compare

September 9, 2024 16:34

tiborsimko deleted the branch cernopendata:cms-2016-sim-test

September 9, 2024 16:39

tiborsimko closed this

Member

tiborsimko commented Sep 9, 2024

Hi @danaalsharif @d0leh I see that this PR was made against #207, so upon merging that one, this PR was automatically closed by Github... and I don't seem to be able to reopen it myself... However I have rebased and updated your local branch (d0leh/cms-2017-optimize), so just please open a new pull request against master this time.

(Note: the PRs are to be always opened against master, not against some not-yet-ready merged PRs since that is a volatile target...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet