Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistency: adjusted licenses to consistent names #3697

Closed
wants to merge 1 commit into from

Conversation

Biscgit
Copy link
Member

@Biscgit Biscgit commented Nov 7, 2024

No description provided.

@Biscgit Biscgit requested a review from psaiz November 7, 2024 15:15
@@ -144,7 +144,7 @@
"education"
],
"license": {
"attribution": "MIT Open Source license"
"attribution": "MIT License"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to take the occasion of licence value clean-up and move towards the SPDX standard license values everywhere. This will help to improve FAIR score in tools like FUJ-I. We'll need small amendments in the Jinja templates accordingly as well. Please see #3111 for all details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just saw your issue. Do you have something like this in mind on how to improve the annotation on the license attributions:

"license": {
    "identifier": ...
    "full_name": ...
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity, it would be good to stick to the current data model, using the same license.attribution field, b with values containing standardised license identifiers (such as CC0-1.0). And, in order to display the full name, we could have a Jinja helper function on the infrastructure side translating identifiers to the standardised full license names (such as Creative Commons Zero v1.0 Universal) following the SPDX nomenclature. (We could perhaps even make a link to the license in question.) And, to be on the safe side, for any new licence string we may introduce in thefuture that the Jinja helper function does not recognise, we would display just the text.

Since we are using only a handful of licenses, this approach should do, and has the merit of keeping the same data model.

@Biscgit Biscgit closed this Nov 15, 2024
@Biscgit Biscgit deleted the make-licenses-consistent branch November 15, 2024 15:00
@Biscgit
Copy link
Member Author

Biscgit commented Nov 15, 2024

It made more sense to move development focus to the standardizing directly. Follow #3111 for further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants