scan: fix missing newline, make less noisy (#601)

* scan: fix missing newline, make less noisy

* improve comment wording

pkg/render/terminal_brief.go

@@ -42,14 +42,16 @@ func (r TerminalBrief) File(_ context.Context, fr *malcontent.FileReport) error
 
 	for _, b := range fr.Behaviors {
 		content := fmt.Sprintf("│     %s %s — %s", riskColor(fr.RiskLevel, "•"), riskColor(fr.RiskLevel, b.ID), b.Description)
+		fmt.Fprint(r.w, content)
+
 		e := evidenceString(b.MatchStrings, b.Description)
 
 		// no evidence to give
 		if e == "" {
+			fmt.Println(r.w, "")
 			continue
 		}
 
-		fmt.Fprint(r.w, content)
 		color.New(color.FgHiBlack).Fprint(r.w, ":")
 		e = color.RGB(255, 255, 255).Sprint(e)
 

pkg/report/report.go

@@ -342,7 +342,7 @@ func mungeDescription(s string) string {
 }
 
 //nolint:cyclop // ignore complexity of 44
-func Generate(ctx context.Context, path string, mrs yara.MatchRules, c malcontent.Config, expath string, logger *clog.Logger) (malcontent.FileReport, error) {
+func Generate(ctx context.Context, path string, mrs yara.MatchRules, c malcontent.Config, expath string, _ *clog.Logger) (malcontent.FileReport, error) {
 	ignoreTags := c.IgnoreTags
 	minScore := c.MinRisk
 	ignoreSelf := c.IgnoreSelf
@@ -464,7 +464,7 @@ func Generate(ctx context.Context, path string, mrs yara.MatchRules, c malconten
 				b.Override = append(b.Override, k)
 				fr.Overrides = append(fr.Overrides, b)
 			case !exists && override:
-				logger.Errorf("Override %s matched with no overridden rule\n", m.Rule)
+				// TODO: return error if override references an unknown rule name
 				continue
 			}