Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify bash for PR creation; quote more strings #755

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

egibs
Copy link
Member

@egibs egibs commented Jan 14, 2025

Even though we've installed Bash in the job container, GitHub seems to be using sh:

sh: third_party/yara/YARAForge/RELEASE: unknown operand

This PR explicitly tells the PR creation step to run via bash when we create the third-party update PR so that the [[ test will succeed.

I also went through and quoted remaining string variables for consistency.

@egibs egibs requested a review from stevebeattie January 14, 2025 01:51
@egibs egibs enabled auto-merge (squash) January 14, 2025 01:52
Copy link
Member

@stevebeattie stevebeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't strictly need the bash form of the test here, but as bash is used elsewhere in the update process, it won't exactly hurt anything either.

Thanks for fixing up more of the variable quoting!

@egibs egibs merged commit 37d9412 into chainguard-dev:main Jan 14, 2025
9 checks passed
@egibs egibs deleted the specify-bash-for-3p-workflow branch January 17, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants