Fix #4
Closed
Fix #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mplsgrant <[email protected]>
As we have done for the rest of the ecosystem; bump the MSRV to Rust `v1.56.1` - enables edition 2021.
a9be191 add getzmqnotifications integration test (Antoni Spaanderman) b8fa99d add getzmqnotifications rpc (Antoni Spaanderman) Pull request description: this rpc gives information about the active zmq publishers of bitcoin core currently `get_zmq_notifications` returns a Vec directly from bitcoind, but a structure like getindexinfo could also be used because the possible values of the "type" field are known ACKs for top commit: apoelstra: ACK a9be191 tcharding: ACK a9be191 Tree-SHA512: b9c617de9c8f356e259eaf685be63f14b2608a6433d54ed28450c48c740b07af913a217802e8aec49b92c56be559e4b3c7be23a83163c0f8e4bc300c2107c047
e7a438b Bump MSRV to Rust 1.56.1 (Tobin C. Harding) Pull request description: As we have done for the rest of the ecosystem; bump the MSRV to Rust `v1.56.1` - enables edition 2021. ACKs for top commit: apoelstra: ACK e7a438b Tree-SHA512: 9988ec3449aa3792f867326e5e50b492bb55a7eddabbaaaa86e280891815cd4e8d60c6c95d1118bf69256b71d027f6306abfadbc650ba68de7ec173ba61a503d
…nsactionOptions f8a1622 Add comment clarifying fee rate in FundRawTransactionOptions (Casey Rodarmor) Pull request description: I think this is potentially a bit of a footgun and deserves some clarification. `fundrawtransaction` has two different ways to specify fee rate, `fee_rate`, and `feeRate`. From [the docs](https://developer.bitcoin.org/reference/rpc/fundrawtransaction.html): ``` "fee_rate" - Specify a fee rate in sat/vB. "feeRate" - Specify a fee rate in BTC/kvB. ``` This is extra confusing because the field in FundRawTransactionOptions is called `fee_rate`, but is serde renamed to camelCase, so becomes `feeRate`. This PR adds a comment to `FundRawTransactionOptions::fee_rate` clarifying that it's in kvB and not vB, and corresponds to the `feeRate` argument to `fundrawtransaction`. I actually think it would it would probably be best if the rust field were renamed to `fee_rate_per_kvb`, and manually renamed to `feeRate` when serializing, but this is good quick fix. ACKs for top commit: tcharding: ACK f8a1622 Tree-SHA512: 3ec1c4d5dcce51b3f14cc4825667c4fda29b818dbc9b4aa8bc5d909bdaa547d5d19f78a32b2bd406f67a5344ee0574ebcbd239a7301532fb7685b1bfd2b6dc5b
2e4dac9 Replace Signature with Message Signature (Masud) Pull request description: When attempting to use verify_message() function, using Singature kept leading to InvalidSignature. As such, we replaced Signature with MessageSignature from bitcoin::sign_message::MessageSignature. We also noticed that there was a // TODO comment to test verify_message, so we also added a test function and it works with the new MessageSignature. ACKs for top commit: tcharding: ACK 2e4dac9 Tree-SHA512: d6279086c66f420009c5600e3d5028090c8df3a7088d2fbe928d94fc796dedf227b8536295bd231bf5ddc6ad306120685020c4cf6f4f0c631c3075d9ff9f0009
…ultDetail et al d85da1d Derive Serialize and Deserialize for as many API types as possible (Casey Rodarmor) Pull request description: We're implementing `get_transaction` for our [dummy Bitcoin RPC server](https://crates.io/crates/test-bitcoincore-rpc), and we need to construct and return a `GetTransactionResultDetail`, but `GetTransactionResultDetail` doesn't implement `Serialize`. This PR derives `Serialize` for `GetTransactionResultDetail`, as well as the types it contains. ACKs for top commit: tcharding: ACK d85da1d Tree-SHA512: 40e1074deab674d309d9288742ce6f59eef448217ab9cf83ae229df4d91feed6e9a678e0b7814dcb0da760a38210809f4797795bf2565d8bac5f2ff3e2a04c55
…tur… 0b08150 Revert "Merge rust-bitcoin#326: Replace Signature with Message Signature" (Tobin C. Harding) Pull request description: …e with Message Signature" This reverts commit 05f5b82, reversing changes made to c0fc7cb. rust-bitcoin#326 was broken, I should never have merged it. It also should never have gotten past CI. All blame falls on me. ACKs for top commit: apoelstra: ACK 0b08150 Tree-SHA512: d42c6e1c0e21fd6394d295279d13bdc9a3e34e04df13dc2907336f64f68e111cbf80454d25997382a81ceb6da5a8ca6b9fd28f2a489b3a33c9b5e4f68494e827
MSRV build just broke because of a bunch of dependencies. I did not investigate why I just found a set of versions that builds.
…nt::call() 308448d Use 'serde_json::value::to_raw_value' (Roman Zeyde) Pull request description: Since MSRV is 1.56.1: https://github.com/rust-bitcoin/rust-bitcoincore-rpc#minimum-supported-rust-version-msrv ACKs for top commit: tcharding: ACK 308448d Tree-SHA512: 2a3aec5d1407b2757d18fa10520ff2fe2a52d1eebd6a6f04e49a1a0cc1d6cfb82f3a3f8ae65ef862f703b23cd0613c0d467387c18cfeaf61e01112a2e71d497b
30c5ea7 CI: Fix pinning (Tobin C. Harding) Pull request description: MSRV build just broke because of a bunch of dependencies. I did not investigate why I just found a set of versions that builds. There are more CI fixes in the wind, this just makes the MSRV job pass because all PRs are currently held up by the failing job. ACKs for top commit: apoelstra: ACK 30c5ea7 Tree-SHA512: 784461836c8a5824026c07ab64faa5c3db2ab414c6ab19f62e61af3b002f290c816209167646cbf7f40b6053d4a06c1ff2602e2467a4154eb485a53d6f118cdc
Make the indentation like it is in other repositories in this org. Done in preparation for further patching of the workflow. Whitespace only.
We have a CI script in the `rust-bitcoin-maintainer-tools` repository, lets use it. Requires adding `Cargo-minimal.lock` and `Cargo-recent.lock`. Both these lock files are tested with all three toolchains (msrv, stable, nightly). Note, I could not find a more recent set of dependencies that works so the two lock files are the same.
We deprecate a variant in `GetPeerInfoResultNetwork` that causes clippy to give a false positive. Adding an attribute on the enum does not quitet it down, just add a module level attribute. This warning has been here for ever.
48424da Allow deprecated in main lib module (Tobin C. Harding) Pull request description: We deprecate a variant in `GetPeerInfoResultNetwork` that causes clippy to give a false positive. Adding an attribute on the enum does not quitet it down, just add a module level attribute. This warning has been here for ever. ACKs for top commit: apoelstra: ACK 48424da super weird. I guess we ought to file a bug Tree-SHA512: 1b533c2b97aa23cfa527d63ed38d2cd202480deaec95e3ec3c0667b456614a2e1f8792ae59faad8690b9a51e47bae08c449d9888a42f5e33cea804a3c0bf7048
…ing sequence. 87c95f6 Allow warnings to be either a string or a string sequence. (Arik Sosman) Pull request description: In recent versions of bitcoind, `getblockchaininfo` returns a result whose `warnings` key is no longer a string, but an array of strings. This PR allows the parsing of either. Fixes rust-bitcoin#352. ACKs for top commit: tcharding: ACK 87c95f6 apoelstra: ACK 87c95f6 also assuming that you tested this against an actual recent node Tree-SHA512: eccf2efe9ee69f4523cdb49d9b3d314a2a246991dccd3840b377523e38847640ec7ecbfcb6e0469f6b8bf355e51d5870e86402ee574327b0b4668130f3a0e351
…e CI 93602a9 CI: Use script from rust-bitcoin-maintainer-tools (Tobin C. Harding) 41c457e CI: Reduce indentation (Tobin C. Harding) Pull request description: Use the new maintainer tools test script we created in rust-bitcoin/rust-bitcoin-maintainer-tools#4 For this repo usage of the script is a big change, the coverage does not change that much except we run one example instead of just building it and we run cargo using `cargo --locked` whereas currently for stable and nightly the dependencies used are much more recent. FTR: - We do not format (exists in current ci but is not enforced because of bug is `test.sh`) - We just build the examples (same as current behaviour) - We do not lint (same as current behaviour) - We do not pin, instead we commit a lock file with working dependency versions. Please note that there are two lock files as is customary but in this repo I was unable to get a set of more recent dependencies to build so both files are the same. This replaces rust-bitcoin#338 ACKs for top commit: apoelstra: ACK 93602a9 Tree-SHA512: 67a298fddb670714fd27736341b2aa922208d45baadffefc7a9b8dc2ebd48d551b8fc36426bea06d89cddd901ae7feeaf0ebe16ec4668cc3066056f9bb6cd580
e03cd64 Support multiple warnings in RPC responses (Roman Zeyde) Pull request description: Following rust-bitcoin#353. Tested on latest bitcoind (bitcoin/bitcoin@2cedb42) with latest electrs (romanz/electrs@7773c26). ACKs for top commit: apoelstra: ACK e03cd64 neat! that was easy Tree-SHA512: df9c038f8e1ccac54a07ad13c7ed87f3a92909c20128fcb598b9891d59127a289bbaf79f9a505d9c87347ffd79dc2aaa063ad750126dbd95a916541d032f4106
Depend on the latest release of `rust-bitcoin`.
`just` makes invocations of various tools more discoverable and gives a quick way to run them.
3a3446a Depend on bitcoin v0.32.0 (Tobin C. Harding) Pull request description: Done on top of rust-bitcoin#348 because I had to pin in the CI script, draft until that goes in. Depend on the latest release of `rust-bitcoin`. ACKs for top commit: apoelstra: ACK 3a3446a nice! lots of slight improvements here Tree-SHA512: badf1b26a030985c55a807b916e00c4199d5260ef69664ac6fc4db0182a13dc4433ca26f773d4ecbc9b61f5400f82c0a5f38d05f183e9a8aa6242f06a60397ed
Upgrade to the latest released `jsonrpc` version.
dfc5f86 Upgrade jsonrpc dependency to v0.18.0 (Tobin C. Harding) Pull request description: Just the last patch, upgrade to the latest `jsonrpc` release. There are a bunch of changes it the lock files, this is because of the removal of the range dependency in `bitcoind`. ACKs for top commit: apoelstra: ACK dfc5f86 Tree-SHA512: 763a9ecbde90c5fd7a2947139d7c523995ddb97a0ca92630612bb5bb9bdc335d9fc5bead364a22d143f336e7b08344026eb952af854ec7359d14a2dd34d0568d
Currently we activate the "bitcoin/rand-std" feature unconditionally in `json`. Some users may not wish to use the bitcoin "rand" feature. Add a "rand" feature to `json` and `client` and use it to activate "rand-std" in `bitcoin`. The crates currently have no features, this is the first. In order to be less of a breaking change also add a "default" feature and enable "rand" from "default".
Recently in `jsonrpc` we added an HTTP client that uses `minreq`. Since we now use a version of `jsonrpc` with this feature we can now use `minreq` here.
6b3fdd1 Add a justfile (Tobin C. Harding) Pull request description: `just` makes invocations of various tools more discoverable and gives a quick way to run them. ACKs for top commit: apoelstra: ACK 6b3fdd1 Tree-SHA512: 2963b7380c8d8f02860e5a914a2249a3c7b17a61101f8d7eefc5bea4d590e8a05f07623155564279357300ccac49633832b94f337acefceaa010e3392c2cc02d
93e9af8 Use minreq_http feature of jsonrpc (Tobin C. Harding) Pull request description: Recently in `jsonrpc` we added an HTTP client that uses `minreq`. Since we now use a version of `jsonrpc` with this feature we can now use `minreq` here. ACKs for top commit: apoelstra: ACK 93e9af8 Tree-SHA512: ad23bb15a5f03f9f9d2e41bf88e4fdbd0fb470b18a708f88b1b7357152f9e9f869ea1791024c88155f6b1eeec9de7d916155564f611df24f69aede9044e2053e
af66cfe Add rand feature (Tobin C. Harding) Pull request description: Currently we activate the "bitcoin/rand-std" feature unconditionally in `json`. Some users may not wish to use the bitcoin "rand" feature. Add a "rand" feature to `json` and `client` and use it to activate "rand-std" in `bitcoin`. The crates currently have no features, this is the first. In order to be less of a breaking change also add a "default" feature and enable "rand" from "default". ACKs for top commit: apoelstra: ACK af66cfe Tree-SHA512: 50e8c5b17bd20623ce2f4c46cf2fcdd0eec6fb3c177a68536033b50d9ae5f4e57be9a8f2e8223a0a9855f3c1c704d3b258878bb7e9bdfc03c8362ab8e02fe7b3
We use a single changlog for both `client` and `json` but there is an old stale changelog file sitting inside `client/` - remove it.
In preparation for release add a changelog entry and bump the version number.
839fcb6 Bump version to 0.19.0 (Tobin C. Harding) 1c60b52 client: Remove stale changelog file (Tobin C. Harding) Pull request description: In preparation for release add a changelog entry and bump the version number. Patch 1 is a trivial cleanup of an old stale changelog file, no longer used. ACKs for top commit: apoelstra: ACK 839fcb6 Tree-SHA512: 445c71f7b5c763862d075a00cf85a0870f58accbe14fdf140e196dc8ec921fd20458996c1a23c688d9f743ccdf4f2c2e452381df8205bde8a89b6b5ed6bb82af
Merge remote & Bump bitcoin to 0.32.2
added 2 commits
August 13, 2024 16:16
yaziciahmet
force-pushed
the
master
branch
3 times, most recently
from
b17732d to
d59fe70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.