add comments to tests

charles-cooper · Jan 15, 2025 · b501329 · b501329
1 parent 0ccac1f
commit b501329
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/tests/functional/codegen/types/test_dynamic_array.py b/tests/functional/codegen/types/test_dynamic_array.py
@@ -1918,6 +1918,7 @@ def foo(a: DynArray[uint256, 4000]) -> uint256:
     assert c.foo(dynarray) == 2
     gas_used = env.last_result.gas_used
     with tx_failed(EvmError):  # catch reverts *and* exceptional halt from oog
+        # should fail pre-cancun due to identity precompile returning 0
         c.foo(dynarray, gas=gas_used - 1)
 
 
@@ -1938,4 +1939,5 @@ def foo(x: String[1000000], y: String[1000000]) -> DynArray[String[1000000], 2]:
     assert c.foo(calldata0, calldata1) == [calldata0, calldata1]
     gas_used = env.last_result.gas_used
     with tx_failed(EvmError):  # catch reverts *and* exceptional halt from oog
+        # should fail pre-cancun due to identity precompile returning 0
         c.foo(calldata0, calldata1, gas=gas_used - 1)
diff --git a/tests/functional/codegen/types/test_lists.py b/tests/functional/codegen/types/test_lists.py
@@ -874,6 +874,8 @@ def foo(x: uint256[3000]) -> uint256:
     assert c.foo(array) == array[0]
     gas_used = env.last_result.gas_used
     with tx_failed(EvmError):  # catch reverts *and* exceptional halt from oog
+        # depends on EVM version. pre-cancun, will revert due to checking
+        # success flag from identity precompile.
         c.foo(array, gas=gas_used - 1)
 
 
@@ -895,4 +897,6 @@ def foo(x: uint256[2500]) -> uint256:
     assert c.foo(array) == array[0]
     gas_used = env.last_result.gas_used
     with tx_failed(EvmError):  # catch reverts *and* exceptional halt from oog
+        # depends on EVM version. pre-cancun, will revert due to checking
+        # success flag from identity precompile.
         c.foo(array, gas=gas_used - 1)