Enable Users to be filtered by whether they are a Partner admin #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-by-whether-they-are-a-Partner-admin # Conflicts: # src/user/user.service.ts
…r-they-are-a-Partner-admin
|
@SangilYun Just to verify, were you able to test that this worked? |
@kyleecodes I tested it by sending HTTP requests to the server from the client side with and without URI encoded object that looks like this and I was able to get only partner admin accounts. Did you get a different result when you tested it? If you have any specific scenarios you'd like me to test, please let me know. |
|
Merged ! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#443 (comment)
What changes did you make?
added logic to handle
IS NOT NULLWhy did you make the changes?
to be able to filter users by whether they are a partner admin or not.