Adds & updates service user profile related tests for covering exceptions calling external apis #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice users profiles spec
…ce - requires some extra mocking and minor reorganisation
…y was not an issue in production but under test the runs could complete before mocked methods were called)
haydnba
changed the title
4 tasks
annarhughes
reviewed
Jun 17, 2024
|
@annarhughes sorry that was a presumptuous late night decision! I'll see what I can do to run the tests without the awaits 👍🏼👍🏼 |
…hub.com:haydnba/bloom-backend into haydnba/test-external-api-errors-not-propagated
annarhughes
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#448
What changes did you make?
serviceUserProfilesutil to cover cases where external api calls fail - test asserts the util method should not propagate the errorpartner-accessservice to cover case where mailchimp api call fails - test asserts the assignment should succeed when where the external api call results in an exceptionuserservice for ensuring the identical scenario does not result in failures to create/update etc. - covers both mailchimp and crisp api calls in dedicated tests as handling these in the same test is redundant (since crisp api is always called first, we would not be testing the same outcome for mailchimp...)awaitsto calls onserviceUserProfilesmethods - this was picked up during testing when it became clear that the test suite was completing before certain mocked methods had been called by the service under test...EDIT removed the awaits as they interfere with desired behaviour on client -> ran tests again without any change and all are passing - basically, as I understood it at the time, the issue was the test suite was completing before all mocked methods were fully executed (because the caller methods were not awaiting the result of the call) and therefore some assertions (e.g. mocked x was called x times) were failing.... hopefully it was just a blip on my machine but it could potentially happen in CI also 🤞🏼
Why did you make the changes?
The team wants to ensure that there is adequate test coverage to prevent a regression allowing external (crisp/mailchimp) api calls to potentially break or interfere with critical flows like user signup...