Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full out fails if larger negative peak #1657

Closed
lpatiny opened this issue Jul 28, 2022 · 1 comment · Fixed by #2800 or #2768
Closed

Full out fails if larger negative peak #1657

lpatiny opened this issue Jul 28, 2022 · 1 comment · Fixed by #2800 or #2768
Assignees
@hamed-musallam
Labels
bug Something isn't working enhancement New feature or request

Comments

@lpatiny
Copy link
Member

lpatiny commented Jul 28, 2022

If negative peaks are larger than positive one the full out zoom is not working correctly in 'center' mode. The negative peaks go outside the boundary.

image

I just added a new method in spectra-processing to solve this issue

mljs/spectra-processing@d173542

It should only be used in 'center' mode I think.
@lpatiny lpatiny added the enhancement New feature or request label Jul 28, 2022
@lpatiny lpatiny added bug Something isn't working and removed priority labels Feb 17, 2023
@lpatiny
Copy link
Member Author

lpatiny commented Dec 6, 2023

You can test with just this spectrum

Image

@hamed-musallam hamed-musallam linked a pull request Dec 13, 2023 that will close this issue
fix: larger negative peak and zoom out #2800
Merged
hamed-musallam added a commit that referenced this issue Dec 13, 2023
@hamed-musallam
fix: large negative spectra peak scale
bead99f 
close #1657
hamed-musallam added a commit that referenced this issue Dec 13, 2023
@hamed-musallam
fix: large negative spectra peak scale
19fd560 
close #1657
@github-project-automation github-project-automation bot moved this from 🔴 Todo to 🟢 Done in NMR and Cheminfo projects organisation Dec 13, 2023
@cheminfo-bot cheminfo-bot mentioned this issue Dec 13, 2023
Merged
hamed-musallam added a commit that referenced this issue Dec 13, 2023
@hamed-musallam
fix: large negative spectra peak scale
e6b8041 
close #1657
hamed-musallam added a commit that referenced this issue Dec 13, 2023
@hamed-musallam
fix: large negative spectra peak scale
32cd140 
close #1657
hamed-musallam added a commit that referenced this issue Dec 13, 2023
@hamed-musallam
fix: large negative spectra peak scale
3262b0d 
close #1657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamed-musallam hamed-musallam

Labels
bug Something isn't working enhancement New feature or request
Projects
NMR and Cheminfo projects organisation
Archived in project
Milestone
No milestone
2 participants
@lpatiny @hamed-musallam