Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: larger negative peak and zoom out #2800

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

hamed-musallam
Copy link
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a5924c
Status: ✅  Deploy successful!
Preview URL: https://3a8d0b65.nmrium.pages.dev
Branch Preview URL: https://fix-larger-negative-peak.nmrium.pages.dev

View logs

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (e8d736b) 2.10% compared to head (0a5924c) 2.06%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/component/utility/getClosePeak.ts 0.00% 31 Missing and 1 partial ⚠️
src/component/utility/maxAbsoluteValue.ts 0.00% 30 Missing and 1 partial ⚠️
src/component/1d/utilities/scale.ts 0.00% 15 Missing ⚠️
src/component/1d/tool/PeakPointer.tsx 0.00% 6 Missing ⚠️
src/component/reducer/actions/PeaksActions.ts 0.00% 3 Missing ⚠️
src/component/hooks/useToolsFunctions.ts 0.00% 2 Missing ⚠️
src/component/toolbar/FunctionToolBar.tsx 0.00% 2 Missing ⚠️
src/component/reducer/helper/Zoom1DManager.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2800      +/-   ##
========================================
- Coverage   2.10%   2.06%   -0.04%     
========================================
  Files        637     638       +1     
  Lines      62367   62372       +5     
  Branches     680     682       +2     
========================================
- Hits        1312    1290      -22     
- Misses     60469   60494      +25     
- Partials     586     588       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam hamed-musallam force-pushed the fix-larger-negative-peak branch 3 times, most recently from 6b42bf3 to 5763ab0 Compare December 13, 2023 19:19
refactor: rename function maxValue to maxAbsoluteValue
@hamed-musallam hamed-musallam force-pushed the fix-larger-negative-peak branch from 5763ab0 to 0a5924c Compare December 13, 2023 19:21
@hamed-musallam hamed-musallam enabled auto-merge (rebase) December 13, 2023 19:21
@hamed-musallam hamed-musallam merged commit c35089f into main Dec 13, 2023
11 of 13 checks passed
@hamed-musallam hamed-musallam deleted the fix-larger-negative-peak branch December 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full out fails if larger negative peak
1 participant