Refactor AlignSpectraModal using react-science modal #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c1da3de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f593a11d.nmrium.pages.dev |
| Branch Preview URL: | https://react-science-modal-alignspe.nmrium.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 53.14% 53.14%
=======================================
Files 51 51
Lines 2497 2497
Branches 90 90
=======================================
Hits 1327 1327
Misses 1169 1169
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Because we need some interaction with the spectrum in order to select from / to, Modal is not the right approach. We propose to replace the content of the panel rather than creating a modal.
|
|
@wadjih-bencheikh18 Please fix the conflicts. |
Refactored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.