refactor database structure search modal #2508
Conversation
Deploying with
|
| Latest commit: |
cb01fd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb2314a3.nmrium.pages.dev |
| Branch Preview URL: | https://database-structure-modal.nmrium.pages.dev |
There was a problem hiding this comment.
Please compare with the current version on https://dev.nmrium.org
- Modal title isn't nice (there's a grey background only around the text)
- Molecule editor is cropped
|
Also, this shouldn't be implemented as a modal, because the results are displayed live in the Database panel while you edit the molecule. I will discuss this with @lpatiny to suggest a replacement. |
|
We will keep this on hold for now. @wadjih-bencheikh18 feel free to migrate other uses of Modal. |
targos
force-pushed
the
database-structure-modal
branch
from
c1cc4e0 to
2872ecb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
=======================================
Coverage 53.46% 53.46%
=======================================
Files 50 50
Lines 2450 2450
Branches 88 88
=======================================
Hits 1310 1310
Misses 1139 1139
Partials 1 1 ☔ View full report in Codecov by Sentry. |
targos
force-pushed
the
database-structure-modal
branch
from
2872ecb to
643cf27
Compare
|
@targos So the current idea is that we have a large Modal that also display the selected molecule 'live'. Is this correct ? But what will happen when we draw the molecule. Will the panel be filtered live as well ? (and we can see it being filtered in the greyed panel ?
|
|
I don't understand what you mean by " display the selected molecule 'live'." |
|
For now we will loose the interaction and we should merge this PR. Please rebase the project to have a final check ? |
Design fixed |
|
There's a conflict. |
Conflict solved |
refs : #1537