Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect negative in auto range picking #2719

Merged

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Oct 20, 2023

No description provided.

@jobo322 jobo322 linked an issue Oct 20, 2023 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98a063a
Status: ✅  Deploy successful!
Preview URL: https://9c62c1e0.nmrium.pages.dev
Branch Preview URL: https://2716-auto-ranges-picking-doe.nmrium.pages.dev

View logs

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f276fa) 52.95% compared to head (98a063a) 52.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2719   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files          50       50           
  Lines        2487     2487           
  Branches       88       88           
=======================================
  Hits         1317     1317           
  Misses       1169     1169           
  Partials        1        1           
Files Coverage Δ
src/data/data1d/Spectrum1D/ranges/detectRanges.ts 63.41% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 merged commit 86530ac into main Oct 23, 2023
13 checks passed
@jobo322 jobo322 deleted the 2716-auto-ranges-picking-does-not-detect-negative-peaks branch October 23, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto ranges picking does not detect negative peaks
1 participant