Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phase correction 2D slices #2748

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Nov 11, 2023

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3508588
Status: ✅  Deploy successful!
Preview URL: https://26e90858.nmrium.pages.dev
Branch Preview URL: https://phase-correction-slices.nmrium.pages.dev

View logs

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (4f0626b) 53.65% compared to head (3508588) 53.57%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2748      +/-   ##
==========================================
- Coverage   53.65%   53.57%   -0.09%     
==========================================
  Files          51       51              
  Lines        2462     2492      +30     
  Branches       88       88              
==========================================
+ Hits         1321     1335      +14     
- Misses       1140     1156      +16     
  Partials        1        1              
Files Coverage Δ
src/data/data2d/Spectrum2D/getSlice.ts 28.12% <21.73%> (+5.67%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam hamed-musallam enabled auto-merge (squash) November 13, 2023 11:55
@hamed-musallam hamed-musallam merged commit 110998a into main Nov 13, 2023
11 of 13 checks passed
@hamed-musallam hamed-musallam deleted the phase-correction-slices branch November 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants