Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectrum nor assignment from jcamp is not loaded #2754

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Nov 17, 2023

No description provided.

@jobo322 jobo322 linked an issue Nov 17, 2023 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 19c408c
Status: ✅  Deploy successful!
Preview URL: https://15175567.nmrium.pages.dev
Branch Preview URL: https://2753-jcamp-assignment-is-not.nmrium.pages.dev

View logs

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (4f0626b) 53.65% compared to head (42f2701) 53.57%.
Report is 2 commits behind head on main.

❗ Current head 42f2701 differs from pull request most recent head 19c408c. Consider uploading reports for the commit 19c408c to get more accurate results

Files Patch % Lines
src/data/data2d/Spectrum2D/getSlice.ts 21.73% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
- Coverage   53.65%   53.57%   -0.09%     
==========================================
  Files          51       51              
  Lines        2462     2492      +30     
  Branches       88       88              
==========================================
+ Hits         1321     1335      +14     
- Misses       1140     1156      +16     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 merged commit c8bee9c into main Nov 17, 2023
11 checks passed
@jobo322 jobo322 deleted the 2753-jcamp-assignment-is-not-loaded branch November 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jcamp assignment is not loaded
1 participant