Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update react-science #2795

Merged
merged 10 commits into from
Dec 12, 2023
Merged

refactor: update react-science #2795

merged 10 commits into from
Dec 12, 2023

Conversation

hamed-musallam
Copy link
Member

@hamed-musallam hamed-musallam commented Dec 7, 2023

Copy link

cloudflare-workers-and-pages bot commented Dec 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 15d2be5
Status: ✅  Deploy successful!
Preview URL: https://5806376c.nmrium.pages.dev
Branch Preview URL: https://update-react-science.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the update-react-science branch 2 times, most recently from 794632e to 6b0440b Compare December 7, 2023 15:11
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 453 lines in your changes are missing coverage. Please review.

Comparison is base (cde96e1) 53.42% compared to head (15d2be5) 2.10%.

Files Patch % Lines
src/component/toolbar/FunctionToolBar.tsx 0.00% 128 Missing ⚠️
src/component/toolbar/BasicToolBar.tsx 0.00% 97 Missing ⚠️
src/component/elements/ContextMenuBluePrint.tsx 0.00% 66 Missing and 1 partial ⚠️
src/component/elements/DropdownMenu.tsx 0.00% 38 Missing and 1 partial ⚠️
...c/component/panels/SpectrumsPanel/SpectraTable.tsx 0.00% 21 Missing ⚠️
src/component/hooks/usePanelPreferences.ts 0.00% 14 Missing ⚠️
...ent/elements/ReactTable/Elements/ReactTableRow.tsx 0.00% 9 Missing ⚠️
...nent/panels/MoleculesPanel/MoleculePanelHeader.tsx 0.00% 8 Missing ⚠️
...rc/component/panels/RangesPanel/RangesTableRow.tsx 0.00% 7 Missing ⚠️
src/component/panels/ZonesPanel/ZonesTableRow.tsx 0.00% 7 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2795       +/-   ##
==========================================
- Coverage   53.42%   2.10%   -51.32%     
==========================================
  Files          52     637      +585     
  Lines        2456   62367    +59911     
  Branches       95     680      +585     
==========================================
  Hits         1312    1312               
- Misses       1143   60469    +59326     
- Partials        1     586      +585     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was linked to issues Dec 11, 2023
refactor: prevent show context menu if there is no options
refactor: simplify the toolbar component
@hamed-musallam hamed-musallam force-pushed the update-react-science branch 5 times, most recently from 753394a to 62f00f5 Compare December 12, 2023 19:13
test: change the exportAs tool selector

test: do not select the the first spectrum

By default, the first spectrum is selected. If you select the spectrum again, it will be deselected
which should not be the case.

test: fix selector

test: fix modal delete button css selector
chore: update react-sciense to version 0.30.1

chore: update react-science to pre release version 0.30.2-pre.1702391005
@hamed-musallam hamed-musallam merged commit 849ed2f into main Dec 12, 2023
11 of 13 checks passed
@hamed-musallam hamed-musallam deleted the update-react-science branch December 12, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react-science New react-science do not have DropdownMenu
2 participants