Add custom eds storage format & block transfer mechanism #343
Conversation
Also synchronous RPDOs should now be transmitted on sync reception Need to add more tests for this last part
…not stored as pure ascii - Added block_transfer bool to use block transfer when reading 0x1021 - Added some documentation example of using upload_eds
This reverts commit 074be34.
- Added storage_format to handler function & added some logging info
|
During the weekend will try to give it a look. |
|
Bump have you had a chance to look at it ? |
There was a problem hiding this comment.
Sorry for the late late response, real live took the best of me. Just some small comments.
The remaining added functionality seems ok. In terms of use I can't test it, so I can't validate. Have you test it using real hardware and everything behaves as it should?
There was a problem hiding this comment.
I can't spot anything wrong with the code,
It is just a small request, please pay some attention to the format of the code, like spaces between parameters when calling functions line 170:
object_dictionary = import_from_node(node, self, block_transfer, eds_format_handler)
remove unnecessary spaces:
eds_format_handler: Callable = None
It's just this small things.
There was a problem hiding this comment.
I can't spot anything wrong with the code, just some small formatting problems, can you please arrange this.
| except Exception as e: | ||
| print(e) |
Hi,
CiA defines objects 0x1021 for storing EDS and object 0x1022 for storing the format used (which suppose to be mandatory according to spec btw).
I've added two optional parameters to add_node :
I've also added some documentation , an example and description for parameters.