Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew Cask for Cinny #316

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/tauri.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
steps:
- name: Checkout repository
uses: actions/[email protected]
with:
with:
submodules: true
- name: Setup node
uses: actions/[email protected]
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
steps:
- name: Checkout repository
uses: actions/[email protected]
with:
with:
submodules: true
- name: Setup node
uses: actions/[email protected]
Expand Down Expand Up @@ -157,6 +157,13 @@ jobs:
src-tauri/target/universal-apple-darwin/release/bundle/dmg/Cinny_desktop-universal.dmg
src-tauri/target/universal-apple-darwin/release/bundle/macos/Cinny_desktop-universal.app.tar.gz
src-tauri/target/universal-apple-darwin/release/bundle/macos/Cinny_desktop-universal.app.tar.gz.sig
- name: Update Homebrew formula
uses: dawidd6/action-homebrew-bump-formula@v3
with:
token: ${{secrets.TOKEN}}
no_fork: true
tap: cinnyapp/cinny-desktop
formula: cinny

# Upload release.json
release-update:
Expand Down
26 changes: 26 additions & 0 deletions Casks/cinny.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
cask "cinny" do
version "4.0.3"
sha256 "1aff22fa0b20b82daf5ab578ed4ed658311226bc5417081a0f4af5d32a84c446"
Comment on lines +2 to +3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the cask be automatically updated or we will have to do it manually? Also will it use the built-in auto update or something else?
If not can we setup something to update the cask file automatically?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are great questions:

  • Updating is now manual, it's a good idea to automate it later
  • Uses the built-in auto update as per cinny.rb#L15
  • We can certainly setup something, like the Homebrew bump formula GitHub Action,
    setting ${{secrets.TOKEN}} and the rest in a .yml.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please setup auto-update along with this addition as we want to automate as much release workflow we can.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Added the GitHub Action, let me know if anything else is needed.


url "https://github.com/cinnyapp/cinny-desktop/releases/download/v#{version}/Cinny_desktop-universal.app.tar.gz"
name "cinny"
desc "Yet another matrix client for desktop"
homepage "https://github.com/cinnyapp/cinny-desktop"

livecheck do
url :url
strategy :github_latest
end

auto_updates true
depends_on macos: ">= :high_sierra"

app "Cinny.app"

zap trash: [
"~/Library/Caches/in.cinny.app",
"~/Library/Preferences/in.cinny.app.plist",
"~/Library/Saved Application State/in.cinny.app.savedState",
"~/Library/WebKit/in.cinny.app",
]
end
Loading