Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to native Intl.DateTimeFormat #1350

Closed
wants to merge 1 commit into from

Conversation

greentore
Copy link
Contributor

@greentore greentore commented Jul 24, 2023

Description

Removes dateformat dependency in favor of native Intl.DateTimeFormat object. 24-hour format is used by default with a settings switch to change it to 12-hour one.

Fixes #60

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

Preview: https://1350--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

Also makes 12/24 clock style configurable
@ajbura
Copy link
Member

ajbura commented Jan 10, 2025

It is not clear why following changes want to remove the dateformat. closing in favor of #1739 for 24 hour clock

@ajbura ajbura closed this Jan 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable time and date format
2 participants