-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voicemail feature #232
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove AttachmentTypes - Added AttachmentFrame Bug: VoiceMailRecorder cannot be stopped using button
injecting 💉a function to return a function Fixed bugs ...
- improved code style according to rules
… "Recording paused" not to be edited
Examples of the bugs this PR solves:
|
- improved code quality
you might want to squash this bruh |
Hi, Thanks for the PR. I have few concerns before reviewing this.
|
Well, I cannot change the commit messages. |
The current design implementation does seems to slow the file uploading as well as recording. Let me spin up some alternative design implementation. |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This adds a feature to record audio/voice from inside cinny's room input and send it as a file.
Also, it replaces the upload file button's function to instead open a new menu to select what the user would like to attach, like a file or voice.
Additionally, this fixes a bug due to changed Webpack behavior where the compilation fails once the browser tries to load the page.
Deeper description
Type of change
Screenshots
Note: The selection of icons can/should be improved
Checklist:
Preview: https://61f81bf6fc0a4a0e439400a8--pr-cinny.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.