Common Controls 12.1: correct Policy API implementation #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
The implementation of the Common Controls 12.1 baseline using the Policy API has been fixed to give the correct results.
The initial implementation assumed a link between the "services without an individual admin control" and the individual takeout admin controls.
Closes #530
🧪 Testing
The tests for the Policy API implementation of Common Controls 12.1 have been updated to reflect the correct takeout setting functionality. The changes were made in
commoncontrols_api12_test.rego
.The takeout settings were altered using the scubagws Admin UI to confirm that the correct result was produced by ScubaGoggles.
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist