Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edtf format validator #422

Closed
wants to merge 6 commits into from
Closed

edtf format validator #422

wants to merge 6 commits into from

Conversation

retorquere
Copy link

Description

Adds edtf format validator library for 4 json-schema validators (example of use in test)

Fixes #421

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Variable addition (adds a new variable or type string)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have installed the repo pre-commit hook; if not, and I have modified any of the schema files, I have run trang and/or prettier on the files, per CONTRIBUTING
  • I have performed a self-review of my own code
  • I have included suggested corresponding changes to the documentation (if relevant)

I am not sure where this should be documented.

@bdarcus
Copy link
Member

bdarcus commented Jun 6, 2022

Do I understand #421 (comment) correctly, @retorquere: are you moving most of this to an EDTF.js PR, and reducing this to examples for the test script?

So I'll wait for that to merge, and you to update this?

@retorquere
Copy link
Author

Do I understand #421 (comment) correctly, @retorquere: are you moving most of this to an EDTF.js PR, and reducing this to examples for the test script?

So I'll wait for that to merge, and you to update this?

Yeah that seems best.

@bdarcus
Copy link
Member

bdarcus commented Jun 6, 2022

OK.

BTW, I think we would merge this to the 1.1 branch.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EDTF regex to be more lenient, or use custom format instead
2 participants