-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update New Hart's Rules (#7105) #7106
base: master
Are you sure you want to change the base?
update New Hart's Rules (#7105) #7106
Conversation
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: new-harts-rules-the-oxford-style-guide.csl (modified style)Bob Hancké, Martin Rhodes and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York, 2007); ‘CSL Search by Example’, Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/, accessed 15 Dec. 2012. -Bob Hancké, Martin Rhodes and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York, 2007); ‘CSL Search by Example’, <i>Citation Style Editor</i>, 2012 <http://editor.citationstyles.org/searchByExample/> [accessed 15 December 2012].<br/>
-Isabela Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. by Peter A. Hall and David Soskice (New York, 2001), 184–213; Martin Fenner and others, ‘A Data Citation Roadmap for Scholarly Data Repositories’, <i>Scientific Data</i>, 6/1 (2019), 28 <http://www.nature.com/articles/s41597-019-0031-8> [accessed 27 April 2019].<br/>
+Bob Hancké, Martin Rhodes and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York, 2007); ‘CSL Search by Example’, <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/, accessed 15 Dec. 2012.<br/>
+Isabela Mares, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in Peter A. Hall and David Soskice, eds., <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> (New York, 2001), 184–213; Martin Fenner and others, ‘A Data Citation Roadmap for Scholarly Data Repositories’, <i>Scientific Data</i>, 6/1 (2019), 28. doi:10.1038/s41597-019-0031-8.<br/>
<hr/>
-‘CSL Search by Example’, <i>Citation Style Editor</i>, 2012 <http://editor.citationstyles.org/searchByExample/> [accessed 15 December 2012]<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, and others, ‘A Data Citation Roadmap for Scholarly Data Repositories’, <i>Scientific Data</i>, 6/1 (2019), 28 <http://www.nature.com/articles/s41597-019-0031-8> [accessed 27 April 2019]<br/>
-Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York, 2007)<br/>
-Mares, Isabela, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. by Peter A. Hall and David Soskice (New York, 2001), 184–213<br/>
+‘CSL Search by Example’, <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/, accessed 15 Dec. 2012.<br/>
+Fenner, Martin and others, ‘A Data Citation Roadmap for Scholarly Data Repositories’, <i>Scientific Data</i>, 6/1 (2019), 28. doi:10.1038/s41597-019-0031-8.<br/>
+Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York, 2007).<br/>
+Mares, Isabela, ‘Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?’, in Peter A. Hall and David Soskice, eds., <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> (New York, 2001), 184–213.<br/>
|
The sample citations look correct. Are there any other requested changes for this style at this time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a few comments on formatting to prevent extra punctuation from being added
<text term="in" suffix=" "/> | ||
<names variable="editor"> | ||
<name and="text" delimiter=", "/> | ||
<label form="short" text-case="lowercase" prefix=", "/> | ||
</names> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<text term="in" suffix=" "/> | |
<names variable="editor"> | |
<name and="text" delimiter=", "/> | |
<label form="short" text-case="lowercase" prefix=", "/> | |
</names> | |
<group delimiter=" "> | |
<text term="in"/> | |
<names variable="editor"> | |
<name and="text" delimiter=", "/> | |
<label form="short" text-case="lowercase" prefix=", "/> | |
</names> | |
</group> |
@@ -242,9 +246,16 @@ | |||
</macro> | |||
<macro name="container-title-note"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put the term and container title inside a group with delimiter=" "
like I did with the above macro?
This will prevent "in" from being printed if there is no container title
</date> | ||
</group> | ||
<if variable="DOI"> | ||
<text variable="DOI" prefix=". doi:"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move the ". " to be a delimiter on a group containing these items, rather than using prefix/suffix for punctuation? This will prevent extra punctuation from being added when a variable is missing.
Please do this for all do the delimiters between elements in this macro
Thanks for the crit. I will respond with changes. |
update New Hart's Rules (#7105)